[issue29655] Certain errors during IMPORT_STAR can leak a reference

Serhiy Storchaka added the comment: New changeset 160edb43571311a3785785c1dfa784afc52d87be by Serhiy Storchaka (Matthias Bussonnier) in branch 'master': bpo-29655: Fixed possible reference leaks in `import *`. (#301) https://github.com/python/cpython/commit/160edb43571311a3785785c1dfa784afc52d8

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Berker Peksag added the comment: New changeset 0dadf56737f591c83d18db5e445960d39448583e by Berker Peksag in branch '3.5': bpo-29655: Fixed possible reference leaks in `import *`. (#301) (#349) https://github.com/python/cpython/commit/0dadf56737f591c83d18db5e445960d39448583e -- __

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Berker Peksag added the comment: New changeset 7accf2033d03025cc5324f8b9d22582bca3623e9 by Berker Peksag in branch '3.6': bpo-29655: Fixed possible reference leaks in `import *`. (#301) (#348) https://github.com/python/cpython/commit/7accf2033d03025cc5324f8b9d22582bca3623e9 -- __

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Serhiy Storchaka added the comment: New changeset 9fbb65e6464b56c6d677090e185c9fe16a80ed96 by Serhiy Storchaka in branch '2.7': bpo-29655: Fixed possible reference leaks in `import *`. (#301) (#510) https://github.com/python/cpython/commit/9fbb65e6464b56c6d677090e185c9fe16a80ed96 --

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Changes by Serhiy Storchaka : -- pull_requests: +419 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Serhiy Storchaka added the comment: But it is *very easy* to fix this bug in 2.7. -- keywords: +patch resolution: fixed -> stage: resolved -> patch review status: closed -> open versions: +Python 2.7 -Python 3.5, Python 3.6, Python 3.7 Added file: http://bugs.python.org/file46678/issue2

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Berker Peksag added the comment: I ignored 2.7 because you know... it's 2.7 :) And you said [1] that it doesn't have a big effect on real applications. [1] https://github.com/python/cpython/pull/301#issuecomment-282789185 -- nosy: +berker.peksag ___

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Serhiy Storchaka added the comment: It looks to me that 2.7 has this bug. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Changes by Berker Peksag : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed versions: -Python 2.7 ___ Python tracker ___ __

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Changes by Berker Peksag : -- pull_requests: +301 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Changes by Berker Peksag : -- pull_requests: +300 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Changes by Matthias Bussonnier : -- pull_requests: +267 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> needs patch type: behavior -> resource usage versions: +Python 2.7, Python 3.5, Python 3.6 ___ Python tracker

[issue29655] Certain errors during IMPORT_STAR can leak a reference

Changes by Matthias Bussonnier : -- nosy: +mbussonn ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue29655] Certain errors during IMPORT_STAR can leak a reference

New submission from Peter Cawley: In the implementation of the IMPORT_STAR opcode, if the call to PyFrame_FastToLocalsWithError fails, or f_locals is NULL, then control flow jumps to the error handler without performing a decref on the "from" variable. As the "from" variable is initialised by