[issue29654] SimpleHTTPRequestHandler should support browser cache

2017-07-31 Thread STINNER Victor
STINNER Victor added the comment: I suppose temp.flush() is a remnant of other (unsuccessful) attempt to fix a race condition. I didn't try only with .flush(). I prefer to explicitly .flush(), just in case :-) Using correctly a file system is complex because of all layers of caching. --

[issue29654] SimpleHTTPRequestHandler should support browser cache

2017-07-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Victor! I suppose temp.flush() is a remnant of other (unsuccessful) attempt to fix a race condition. -- ___ Python tracker ___ ___

[issue29654] SimpleHTTPRequestHandler should support browser cache

2017-07-29 Thread Pierre Quentel
Pierre Quentel added the comment: Thanks for telling me. I must have run the test hundreds of times now, on a Windows 7 PC, and this bug never occured. Just for my information, why do you add temp.flush() in the "with" block ? I thought the context manager took care of this. 2017-07-28 18:19 GM

[issue29654] SimpleHTTPRequestHandler should support browser cache

2017-07-28 Thread STINNER Victor
STINNER Victor added the comment: FYI there was a race condition, impacting Windows. I just fixed it: bpo-31066, commit 28ce07ae9e34c70eea6b52515c7e1cefd41e. -- nosy: +haypo ___ Python tracker

[issue29654] SimpleHTTPRequestHandler should support browser cache

2017-04-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your contribution Pierre. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue29654] SimpleHTTPRequestHandler should support browser cache

2017-04-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 351adda54bed3afbbf6db7725699679e68722d7d by Serhiy Storchaka (Pierre Quentel) in branch 'master': bpo-29654 : Support If-Modified-Since HTTP header (browser cache) (#298) https://github.com/python/cpython/commit/351adda54bed3afbbf6db7725699679e6

[issue29654] SimpleHTTPRequestHandler should support browser cache

2017-03-03 Thread Glenn Linderman
Changes by Glenn Linderman : -- nosy: +v+python ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue29654] SimpleHTTPRequestHandler should support browser cache

2017-02-25 Thread Roundup Robot
Changes by Roundup Robot : -- pull_requests: +264 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue29654] SimpleHTTPRequestHandler should support browser cache

2017-02-25 Thread Pierre Quentel
New submission from Pierre Quentel: SimpleHTTPServer send a Last-Modified response header, but doesn't take into account the If-Modified-Since header if it was sent by the user agent. If a url matches a file and this file was not modified after the value of the If-Modified-Since header, the s