[issue29355] sqlite3: remove sqlite3_stmt_readonly()

2017-02-26 Thread Berker Peksag
Berker Peksag added the comment: The patch for issue 28518 has been merged and it doesn't contain any use of sqlite3_stmt_readonly(). Closing this as 'out of date'. Thanks again Ma! -- resolution: -> out of date stage: -> resolved status: open -> closed __

[issue29355] sqlite3: remove sqlite3_stmt_readonly()

2017-02-22 Thread Berker Peksag
Berker Peksag added the comment: > - if (!sqlite3_stmt_readonly(self->statement->st)) { > + if (self->statement->is_dml) { Ah, yes now I understand what do you mean! :) I agree and this is already in my local branch to fix issue 28518. -- ___ Python

[issue29355] sqlite3: remove sqlite3_stmt_readonly()

2017-02-22 Thread Ma Lin
Ma Lin added the comment: The "old way" is not using sqlite3_stmt_readonly(). Before 3.6.0, we only count rowcount for INSERT, UPDATE, DELETE, REPLACE: https://hg.python.org/cpython/file/3.5/Modules/_sqlite/cursor.c#l689 These four statements can be representd by is_dml in PR 245: https://githu

[issue29355] sqlite3: remove sqlite3_stmt_readonly()

2017-02-22 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, Ma. > We can use the old way in here, the old way is even better IMO. What do you mean by the old way? The use of switch statement? -- dependencies: +execute("begin immediate") throwing OperationalError __

[issue29355] sqlite3: remove sqlite3_stmt_readonly()

2017-02-20 Thread Ma Lin
Ma Lin added the comment: > Is there currently a solution to build Python 3.6 with sqlite3 support? I installed SQLite 3.16.2 on a Debian-based system with this way: http://stackoverflow.com/questions/26261080 No idea whether it will work on RHEL 6. -- _

[issue29355] sqlite3: remove sqlite3_stmt_readonly()

2017-02-20 Thread Carol Willing
Carol Willing added the comment: Another report of sqlite3 not compiling correctly on RHEL6 (https://github.com/jupyterhub/jupyterhub/issues/991). Is there currently a solution to build Python 3.6 with sqlite3 support? -- nosy: +willingc ___ Python

[issue29355] sqlite3: remove sqlite3_stmt_readonly()

2017-02-15 Thread Palm Kevin
Changes by Palm Kevin : -- nosy: +palm.kevin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue29355] sqlite3: remove sqlite3_stmt_readonly()

2017-01-23 Thread Ma Lin
New submission from Ma Lin: In CPython 3.6.0, sqlite3 module uses sqlite3_stmt_readonly(), however this function is only available on SQLite 3.7.4+ (release on 2010-12-07). Then CPython 3.6.0 can not be compiled on RHEL6 (with SQLite 3.6.x), complaints: issue29098, issue29325. sqlite3_stmt_rea