[issue2912] let platform.uname try harder

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Ok. I applied the patch in r64233. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> _

[issue2912] let platform.uname try harder

Marc-Andre Lemburg <[EMAIL PROTECTED]> added the comment: On 2008-06-13 16:59, Benjamin Peterson wrote: > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > Wow, I really admire you for keeping it compatible with Python 1.5. As > you may have noticed, I'm addicted to new feature. :) Y

[issue2912] let platform.uname try harder

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Wow, I really admire you for keeping it compatible with Python 1.5. As you may have noticed, I'm addicted to new feature. :) Added file: http://bugs.python.org/file10620/platform4.diff ___ Python tracke

[issue2912] let platform.uname try harder

Marc-Andre Lemburg <[EMAIL PROTECTED]> added the comment: On 2008-06-13 16:20, Benjamin Peterson wrote: > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > Ok. I ran it through reindent.py and removed the True and False. Thanks, but the all() is still there :-) You can change that t

[issue2912] let platform.uname try harder

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Ok. I ran it through reindent.py and removed the True and False. Added file: http://bugs.python.org/file10619/platform3.diff ___ Python tracker <[EMAIL PROTECTED]> ___

[issue2912] let platform.uname try harder

Marc-Andre Lemburg <[EMAIL PROTECTED]> added the comment: There are two patches. Which one do you want me to look at ? Note that platform.py should stay Python 1.5.2 compatible, ie. no new builtins, no True/False. The second patch also appears to mix tabs/spaces. __

[issue2912] let platform.uname try harder

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Marc, could you look at this please? -- assignee: -> lemburg nosy: +lemburg ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue2912] let platform.uname try harder

James Thomas <[EMAIL PROTECTED]> added the comment: Your patch works perfectly on windows. Thanks for your help. ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue2912] let platform.uname try harder

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Thanks for doing this. Would you please try on Windows the patch, I'm attaching now? Added file: http://bugs.python.org/file10607/platform2.diff ___ Python tracker <[EMAIL PROTECTED]>

[issue2912] let platform.uname try harder

James Thomas <[EMAIL PROTECTED]> added the comment: Here is the patch (apply to platform.py) -- keywords: +patch Added file: http://bugs.python.org/file10594/platform.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue2912] let platform.uname try harder

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: >Ah, ok, the code under except AttributeError: gives me some good ideas. >Should I use the methods utilized there to extract information from the >system? Right on! You don't need to write any new code, just make sure the code under the ex

[issue2912] let platform.uname try harder

James Thomas <[EMAIL PROTECTED]> added the comment: Ah, ok, the code under except AttributeError: gives me some good ideas. Should I use the methods utilized there to extract information from the system? ___ Python tracker <[EMAIL PROTECTED]>

[issue2912] let platform.uname try harder

James Thomas <[EMAIL PROTECTED]> added the comment: Alright, that makes things much clearer. I'm looking at this code snippet in platform.py: if system == 'unknown': system = '' if node == 'unknown': node = '' if release == 'unknown': release = '' if versi

[issue2912] let platform.uname try harder

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Thanks for volunteering, James! I think you misunderstood the task. Do you see how in platform's uname, it only tries to find missing values for os.uname if os.uname doesn't exist? Sometimes os.uname exists, but it doesn't provide all the v

[issue2912] let platform.uname try harder

James Thomas <[EMAIL PROTECTED]> added the comment: much handling code already seems to exist under the line except AttributeError: in platform.py (function uname(), lines 1101-1161 platform.py) i'm not too familiar with the Python codebase (i just began developing with Python a few days back) _

[issue2912] let platform.uname try harder

James Thomas <[EMAIL PROTECTED]> added the comment: i'm looking at the source and there doesn't appear to be a function uname within os.py. are we just considering the uname function in platform.py? ___ Python tracker <[EMAIL PROTECTED]>

[issue2912] let platform.uname try harder

James Thomas <[EMAIL PROTECTED]> added the comment: I can work on this task. -- nosy: +jjt009 ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue2912] let platform.uname try harder

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- components: +Library (Lib) priority: -> low __ Tracker <[EMAIL PROTECTED]> __ ___ Python-b

[issue2912] let platform.uname try harder

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- versions: +Python 2.6 __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list U

[issue2912] let platform.uname try harder

New submission from Benjamin Peterson <[EMAIL PROTECTED]>: Sometimes os.uname (which is used to bootstrap platform.uname) can return 'unknown' for some items. The fallback code in platform.uname can usually fill these blanks in. However, this is only used when os.uname is not present. It would be