[issue29103] Make enum.py pep8 compliant

2016-12-30 Thread Ethan Furman
Ethan Furman added the comment: Thanks Raymond and Jean-Sebastien. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue29103] Make enum.py pep8 compliant

2016-12-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset bf6987b93358 by Raymond Hettinger in branch '3.6': Issue #29103: Remove unused import. Noticed by Jean-Sebastien Bevilacqua. https://hg.python.org/cpython/rev/bf6987b93358 -- nosy: +python-dev ___ Python

[issue29103] Make enum.py pep8 compliant

2016-12-29 Thread Jean-Sebastien Bevilacqua
Jean-Sebastien Bevilacqua added the comment: Hello Raymond Hettinger, Thanks for your advice and your comment. I agree with you that pep8 compliant isn't useful. If you look at my patch, the first change is a unused import, not just a text formatting. Maybe this first change can be useful ? (n

[issue29103] Make enum.py pep8 compliant

2016-12-29 Thread Raymond Hettinger
Raymond Hettinger added the comment: I really don't like how this patch is done or even the spirit of it. To my eyes, some of the code looks worse (especially the addition of trailing backslashes and some odd line-wraps that aren't sensitive to readability or context). I'm going to close thi

[issue29103] Make enum.py pep8 compliant

2016-12-29 Thread R. David Murray
R. David Murray added the comment: In general we do not accept PEP8 patches; it is code churn with insufficient benefit since many modules in the stdlib predate either PEP8 itself or the current version of PEP8. However, enum is a new enough module that I suppose this might get accepted. In

[issue29103] Make enum.py pep8 compliant

2016-12-28 Thread Jean-Sebastien Bevilacqua
New submission from Jean-Sebastien Bevilacqua: Hello, This is my first patch on CPython, so please tell me if I do something wrong. When executing flake8 on Lib/enum.py, there are lot of warning. This patch remove all these warnings. -- components: Library (Lib) files: enum_format.patc