[issue29020] collapse_rfc2231_value has inconsistent unquoting

2017-01-02 Thread bpoaugust
bpoaugust added the comment: If there are concerns about 3rd party code relying on the current behaviour of the function, then just create a new function without the unquoting, and deprecate the original function. The existing function does not always unquote, so any code which relies on it i

[issue29020] collapse_rfc2231_value has inconsistent unquoting

2016-12-29 Thread Eric Lafontaine
Eric Lafontaine added the comment: Hi all, The fix is already provided in issue28945 . Please review it and I would like to flag it as needing more test on more version of python... The patch would just require more Test Case that would check for the filename for preventing re-occurence in t

[issue29020] collapse_rfc2231_value has inconsistent unquoting

2016-12-29 Thread Eric Lafontaine
Changes by Eric Lafontaine : -- nosy: +Eric Lafontaine ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue29020] collapse_rfc2231_value has inconsistent unquoting

2016-12-29 Thread bpoaugust
bpoaugust added the comment: I have just checked and AFAICT collapse_rfc2231_value is only called by get_filename and get_boundary in message.py. Both of these call get_param and default to unquote=True. So in all cases the parameter value passed to collapse_rfc2231_value will already have be

[issue29020] collapse_rfc2231_value has inconsistent unquoting

2016-12-24 Thread bpoaugust
bpoaugust added the comment: Another case is get_filename. The second call to unquote will only change the incoming parameter if the original value was enclosed in <> or "". This is not a common scenario, and was only discovered because a mailer used the form <<>> as a boundary marker (yes, t

[issue29020] collapse_rfc2231_value has inconsistent unquoting

2016-12-19 Thread bpoaugust
New submission from bpoaugust: collapse_rfc2231_value unquotes the value before returning it except here: rawbytes = bytes(text, 'raw-unicode-escape') return str(rawbytes, charset, errors) Why is the text not unquoted in this case? Actually I wonder whether the function should do any unquoting

[issue29020] collapse_rfc2231_value has inconsistent unquoting

2016-12-19 Thread bpoaugust
Changes by bpoaugust : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho