[issue28961] unittest.mock._Call ignores `name` parameter

Changes by Donald Stufft : -- pull_requests: +1011 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue28961] unittest.mock._Call ignores `name` parameter

Berker Peksag added the comment: New changeset 5aa3856b4f325457e8ec1ccf669369f543e1f6b5 by Berker Peksag in branch 'master': bpo-28961: Address my comments from earlier code review (#305) https://github.com/python/cpython/commit/5aa3856b4f325457e8ec1ccf669369f543e1f6b5 -- ___

[issue28961] unittest.mock._Call ignores `name` parameter

Berker Peksag added the comment: New changeset fae59e1aa87ee9598d032e0bd697969a5784025f by Berker Peksag in branch '3.6': bpo-28961: Address my comments from earlier code review (#306) https://github.com/python/cpython/commit/fae59e1aa87ee9598d032e0bd697969a5784025f -- __

[issue28961] unittest.mock._Call ignores `name` parameter

Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue28961] unittest.mock._Call ignores `name` parameter

Changes by Berker Peksag : -- pull_requests: +270 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28961] unittest.mock._Call ignores `name` parameter

Changes by Berker Peksag : -- pull_requests: +269 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28961] unittest.mock._Call ignores `name` parameter

Berker Peksag added the comment: IIRC 3.5.3rc1 is already tagged so the 3.5 branch is open for 3.5.4. Anything that needs to be in 3.5.3 should be cherry-picked by the RM at this point if I'm not mistaken (and note that I don't have time check, but 3.5.3 may be the last bugfix release of 3.5 s

[issue28961] unittest.mock._Call ignores `name` parameter

STINNER Victor added the comment: I applied the latest mock.patch to Python 3.6 and default (future 3.7). I prefer to wait for the 3.5.3 release before backporting the fix to 3.5, the fix is minor, I don't want to annoy the release manager yet. -- _

[issue28961] unittest.mock._Call ignores `name` parameter

Roundup Robot added the comment: New changeset 50424a903593 by Victor Stinner in branch '3.6': Fix unittest.mock._Call: don't ignore name https://hg.python.org/cpython/rev/50424a903593 -- nosy: +python-dev ___ Python tracker

[issue28961] unittest.mock._Call ignores `name` parameter

Michael Foord added the comment: Yep, LGTM as well. Nicely spotted! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue28961] unittest.mock._Call ignores `name` parameter

STINNER Victor added the comment: The latest patch (Jiajun Huang, 2017-01-03 14:34) LGTM. -- ___ Python tracker ___ ___ Python-bugs-li

[issue28961] unittest.mock._Call ignores `name` parameter

Berker Peksag added the comment: The patch looks good to me. There are some styling issues in the test code (e.g. no need to add trailing spaces after commas in some cases), but I can take care of them before committing the patch :) Thanks! -- ___ P

[issue28961] unittest.mock._Call ignores `name` parameter

Jiajun Huang added the comment: sorry about that, fixed. -- Added file: http://bugs.python.org/file46126/mock.patch ___ Python tracker ___ ___

[issue28961] unittest.mock._Call ignores `name` parameter

STINNER Victor added the comment: Please remove "import ipdb; ipdb.set_trace() # TODO remove it" before posting patches ;-) -- nosy: +haypo ___ Python tracker ___ __

[issue28961] unittest.mock._Call ignores `name` parameter

Jiajun Huang added the comment: hi, do this need more test case or something else to be merged? please let me know :) -- ___ Python tracker ___ _

[issue28961] unittest.mock._Call ignores `name` parameter

Jiajun Huang added the comment: code and test case has been updated. -- Added file: http://bugs.python.org/file45922/mock.patch ___ Python tracker ___ ___

[issue28961] unittest.mock._Call ignores `name` parameter

Jiajun Huang added the comment: I think we can write `_Call.__new__` as: def __new__(cls, value=(), name='',...) it's much simpler and readable. -- ___ Python tracker ___ _

[issue28961] unittest.mock._Call ignores `name` parameter

Berker Peksag added the comment: Thanks for the patch, Jiajun. The _Call class is tested in CallTest (located in Lib/unittest/test/testmock/testhelpers.py) Would it be possible to add a test case to make sure that we actually fixed the bug? -- nosy: +berker.peksag stage: commit review

[issue28961] unittest.mock._Call ignores `name` parameter

Changes by Emanuel Barry : -- stage: needs patch -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue28961] unittest.mock._Call ignores `name` parameter

Jiajun Huang added the comment: The new patch has been updated. :) -- Added file: http://bugs.python.org/file45885/mock.patch ___ Python tracker ___ _

[issue28961] unittest.mock._Call ignores `name` parameter

Jiajun Huang added the comment: update the patch file follow the doc(https://docs.python.org/devguide/gitdevs.html) -- Added file: http://bugs.python.org/file45884/mock.patch ___ Python tracker ___

[issue28961] unittest.mock._Call ignores `name` parameter

Jiajun Huang added the comment: Thanks for reply :) the patch has been uploaded. -- keywords: +patch Added file: http://bugs.python.org/file45883/mock_class_call.patch ___ Python tracker ___

[issue28961] unittest.mock._Call ignores `name` parameter

Emanuel Barry added the comment: That indeed looks like a bug. Well spotted :) That code has been there since unittest.mock was added back in March 2012. If I were to guess, I'd say that it should be `if name is None: name = ''`. Care to submit a patch? -- nosy: +ebarry, michael.foord