[issue28823] Simplify compiling to BUILD_MAP_UNPACK

2016-11-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Yury. Simplifying the code was the main purpose. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue28823] Simplify compiling to BUILD_MAP_UNPACK

2016-11-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9ded2433dc2c by Serhiy Storchaka in branch 'default': Issue #28823: Simplified compiling with opcode BUILD_MAP_UNPACK. https://hg.python.org/cpython/rev/9ded2433dc2c -- nosy: +python-dev ___ Python tracke

[issue28823] Simplify compiling to BUILD_MAP_UNPACK

2016-11-28 Thread Yury Selivanov
Yury Selivanov added the comment: While I don't think that merging more than 256 dicts is a common task, the code does become much simpler. LGTM. -- ___ Python tracker ___

[issue28823] Simplify compiling to BUILD_MAP_UNPACK

2016-11-28 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Currently the compiler produces BUILD_MAP_UNPACK with an argument at most 255. If needed to merge more than 255 dictionaries, BUILD_MAP_UNPACK is called several times. But this is unneeded complication since BUILD_MAP_UNPACK doesn't have a limitation on it