[issue28668] instanciation of multiprocessing.Queue raises ImportError in test_logging

Change by Xavier de Gaye : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue28668] instanciation of multiprocessing.Queue raises ImportError in test_logging

Xavier de Gaye added the comment: New changeset bf2b65e413ca5ec705c7e2f463d0d75e947588a4 by xdegaye in branch 'master': bpo-28668: test.support.requires_multiprocessing_queue is removed (GH-4560) https://github.com/python/cpython/commit/bf2b65e413ca5ec705c7e2f463d0d75e947588a4 -- __

[issue28668] instanciation of multiprocessing.Queue raises ImportError in test_logging

Xavier de Gaye added the comment: The multiprocessing module is not functional when the multiprocessing.synchronize module cannot be imported and all the multiprocessing tests are skipped in that case. Use the same idiom (i.e. test.support.import_module('multiprocessing.synchronize')) to skip

[issue28668] instanciation of multiprocessing.Queue raises ImportError in test_logging

Change by Xavier de Gaye : -- pull_requests: +4489 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue28668] instanciation of multiprocessing.Queue raises ImportError in test_logging

Changes by Xavier de Gaye : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue28668] instanciation of multiprocessing.Queue raises ImportError in test_logging

Roundup Robot added the comment: New changeset a377e6987821 by Xavier de Gaye in branch '3.5': Issue 28668: Skip tests where instanciation of multiprocessing.Queue https://hg.python.org/cpython/rev/a377e6987821 New changeset e5404ba1b19e by Xavier de Gaye in branch '3.6': Issue 28668: Merge 3.5

[issue28668] instanciation of multiprocessing.Queue raises ImportError in test_logging

Serhiy Storchaka added the comment: Okay. test_multiprocessing_queue_2.patch LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue28668] instanciation of multiprocessing.Queue raises ImportError in test_logging

Xavier de Gaye added the comment: IMHO other tests in the future may instantiate multiprocessing.Queue() and come up with another new decorator when the test fails on the (yet to come) Android buildbot, ignoring that one already exists if we move the decorator to the test_logging module.

[issue28668] instanciation of multiprocessing.Queue raises ImportError in test_logging

Serhiy Storchaka added the comment: requires_multiprocessing_queue is used only in test_logging. Is it worth to add it in test.support? -- ___ Python tracker ___ ___

[issue28668] instanciation of multiprocessing.Queue raises ImportError in test_logging

Xavier de Gaye added the comment: When the test is to be skipped: * The decorator in the previous patch (a decorator with arguments that takes no argument) returns a decorator which is unittest.skip (to be applied to the test method). * On the other side, the skip_unless_symlink decorator p

[issue28668] instanciation of multiprocessing.Queue raises ImportError in test_logging

Changes by Davin Potts : -- nosy: +davin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue28668] instanciation of multiprocessing.Queue raises ImportError in test_logging

Serhiy Storchaka added the comment: The decorator doesn't need arguments. I would make it similar to skip_unless_symlink. -- nosy: +serhiy.storchaka ___ Python tracker ___ _

[issue28668] instanciation of multiprocessing.Queue raises ImportError in test_logging

New submission from Xavier de Gaye: Occurs on Android that has a broken shared semaphore implementation (issue 26924). Patch attached. One of the backtraces: == ERROR: test_handle_called_with_mp_queue (test.test_logging.QueueL