[issue28633] Concatenating bytes literal and f-string causes segmentation fault

2016-11-07 Thread Eric V. Smith
Changes by Eric V. Smith : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue28633] Concatenating bytes literal and f-string causes segmentation fault

2016-11-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 31543f7cbdf4 by Eric V. Smith in branch '3.6': Fixed issue #28633: segfault when concatenating bytes literal and f-string. https://hg.python.org/cpython/rev/31543f7cbdf4 -- nosy: +python-dev ___ Python tr

[issue28633] Concatenating bytes literal and f-string causes segmentation fault

2016-11-07 Thread Eric V. Smith
Eric V. Smith added the comment: Thanks, Serhiy. I updated the patch. -- Added file: http://bugs.python.org/file45385/28633-1.diff ___ Python tracker ___

[issue28633] Concatenating bytes literal and f-string causes segmentation fault

2016-11-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. I added comments about other asserts. Not related, but would be nice to fix them too while we are here. -- ___ Python tracker ___ _

[issue28633] Concatenating bytes literal and f-string causes segmentation fault

2016-11-07 Thread Eric V. Smith
Eric V. Smith added the comment: It's a decref of a NULL pointer. Patch with test is attached. -- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file45383/28633-0.diff ___ Python tracker

[issue28633] Concatenating bytes literal and f-string causes segmentation fault

2016-11-07 Thread Eric V. Smith
Eric V. Smith added the comment: The ones in msg280228 give correct error messages. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue28633] Concatenating bytes literal and f-string causes segmentation fault

2016-11-07 Thread Honor
Honor added the comment: Another: >>> 9,'''Ðؚ%''(r'''%b"r' File "", line 1 SyntaxError: cannot mix bytes and nonbytes literals >>> 9,'B''Ðؚ%''(r'''%b"r''' Traceback (most recent call last): File "", line 1, in ValueError: incomplete format key >>> 9,'B''Ðؚ%''(r'''%b"r'''F

[issue28633] Concatenating bytes literal and f-string causes segmentation fault

2016-11-07 Thread Eric V. Smith
Eric V. Smith added the comment: Works: >>> f'' b'' File "", line 1 SyntaxError: cannot mix bytes and nonbytes literals Fails: >>> b'' f'' Segmentation fault $ Regular strings work: >>> '' b'' File "", line 1 SyntaxError: cannot mix bytes and nonbytes literals >>> b'' '' File "", line

[issue28633] Concatenating bytes literal and f-string causes segmentation fault

2016-11-07 Thread Eric V. Smith
Changes by Eric V. Smith : -- assignee: -> eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue28633] Concatenating bytes literal and f-string causes segmentation fault

2016-11-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- title: eval() Function - Segmentation Fault -> Concatenating bytes literal and f-string causes segmentation fault ___ Python tracker ___ ___