[issue28480] Compile error on Modules/socketmodule.c

2017-03-31 Thread Donald Stufft
Changes by Donald Stufft : -- pull_requests: +921 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28480] Compile error on Modules/socketmodule.c

2016-10-20 Thread Martin Panter
Martin Panter added the comment: I also committed a similar but independent fix in Python 2.7 building Modules/_sqlite/connection.c, caused by revision 649937bb8f1c, and adjusted some tests to work when multithreading is disabled. For the record, I also opened Issue 28482, Issue 28484 and Issu

[issue28480] Compile error on Modules/socketmodule.c

2016-10-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9316b4ebf3fa by Martin Panter in branch '3.6': Issue #28480: Avoid label at end of compound statement --without-threads https://hg.python.org/cpython/rev/9316b4ebf3fa New changeset 7cb86d404866 by Martin Panter in branch '3.6': Issue #28480: Adjust

[issue28480] Compile error on Modules/socketmodule.c

2016-10-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 17629dee23ca by Martin Panter in branch '2.7': Issue #28480: Avoid label at end of compound statement --without-threads https://hg.python.org/cpython/rev/17629dee23ca -- nosy: +python-dev ___ Python track

[issue28480] Compile error on Modules/socketmodule.c

2016-10-19 Thread Masayuki Yamamoto
Masayuki Yamamoto added the comment: Oh, that's enough to work, Martin. I confirmed too. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue28480] Compile error on Modules/socketmodule.c

2016-10-19 Thread Martin Panter
Martin Panter added the comment: Thanks for the report and patch. I think an empty statement might be better than the dummy assignment. Let me know if the following would work and I will commit it: done: +; /* necessary for --without-threads flag */ Py_END_ALLOW_THREADS -

[issue28480] Compile error on Modules/socketmodule.c

2016-10-19 Thread Masayuki Yamamoto
New submission from Masayuki Yamamoto: _socket module has failed to compile with --without-threads flag since 554fb699af8c, because Py_END_ALLOW_THREADS macro exists behind the done label ( Modules/socketmodule.c:666 ). If --without-threads flag goes on, Py_END_ALLOW_THREADS macro replaces to