[issue28476] Remove redundant definition of factorial on test_random

2016-10-19 Thread STINNER Victor
STINNER Victor added the comment: Thanks for your contribution Francisco. test_random still pass. I pushed your safe and well contained patch. It don't see any good reason why test_random had its own pure (and slow) Python implementation of factorial(), it's probably because test_random.py was

[issue28476] Remove redundant definition of factorial on test_random

2016-10-19 Thread Roundup Robot
New submission from Roundup Robot: New changeset c6588a7443a4 by Victor Stinner in branch 'default': Close #28476: Reuse math.factorial() in test_random https://hg.python.org/cpython/rev/c6588a7443a4 -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -> closed _

[issue28476] Remove redundant definition of factorial on test_random

2016-10-19 Thread Francisco Couzo
Changes by Francisco Couzo : -- components: Tests files: test_random.patch keywords: patch nosy: franciscouzo priority: normal severity: normal status: open title: Remove redundant definition of factorial on test_random Added file: http://bugs.python.org/file45142/test_random.patch