[issue28405] Compile error on Modules/_futuresmodule.c

Changes by Berker Peksag : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue28405] Compile error on Modules/_futuresmodule.c

Roundup Robot added the comment: New changeset a8dd18e375c8 by INADA Naoki in branch '3.6': Issue #28405: Fix compile error for _futuresmodule.c on Cygwin. https://hg.python.org/cpython/rev/a8dd18e375c8 New changeset d2a313d13542 by INADA Naoki in branch 'default': Issue #28405: Fix compile erro

[issue28405] Compile error on Modules/_futuresmodule.c

Ned Deily added the comment: revised patch LGTM -- nosy: +ned.deily ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue28405] Compile error on Modules/_futuresmodule.c

INADA Naoki added the comment: Oh! Thanks, While I ran make, I had missed error message somehow. -- ___ Python tracker ___ ___ Python-

[issue28405] Compile error on Modules/_futuresmodule.c

Masayuki Yamamoto added the comment: Thanks, INADA. I confirmed your solution, and has succeeded to build _futures extension. Your patch has a little misspell. I fixed it. -- Added file: http://bugs.python.org/file45046/gc_track-2.patch ___ Python tr

[issue28405] Compile error on Modules/_futuresmodule.c

INADA Naoki added the comment: I need another LGTM from core developer before committing. Yury, could you see it? This is one line patch. -- ___ Python tracker ___ _

[issue28405] Compile error on Modules/_futuresmodule.c

INADA Naoki added the comment: Thank you for reporting. C-API doc [https://docs.python.org/3.7/c-api/gcsupport.html#c._PyObject_GC_TRACK] says: > A macro version of PyObject_GC_Track(). It should not be used for extension > modules. So simply replacing it to PyObject_GC_Track() may solve the

[issue28405] Compile error on Modules/_futuresmodule.c

Changes by Xiang Zhang : -- nosy: +inada.naoki, yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue28405] Compile error on Modules/_futuresmodule.c

New submission from Masayuki Yamamoto: I tried to build cpython on cygwin (vista x86). Core interpretor has built to success, but '_futures' extension module has failed (compile error on Modules/_futuresmodule.c:946 ). It has occured since f8815001a390 part of build log: $ uname -a CYGWIN_NT-6

[issue28405] Compile error on Modules/_futuresmodule.c

Masayuki Yamamoto added the comment: I searched declaration for _PyGC_generation0, And it has be found at Include/objimpl.h:259 The found declaration hasn't used PyAPI_DATA macro. Hence, I wrote a patch to wrap declaration by the macro. I has succeeded to build _futures module using the patch.