[issue28189] dictitems_contains swallows compare errors

2016-09-18 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks for the merge Raymond. :) -- stage: patch review -> resolved ___ Python tracker ___ ___ Python-b

[issue28189] dictitems_contains swallows compare errors

2016-09-18 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thanks for the patch. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue28189] dictitems_contains swallows compare errors

2016-09-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2a9e0e869ca7 by Raymond Hettinger in branch '3.5': Issue #28189: dictitems_contains no longer swallows compare errors. https://hg.python.org/cpython/rev/2a9e0e869ca7 -- nosy: +python-dev ___ Python tracke

[issue28189] dictitems_contains swallows compare errors

2016-09-18 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28189] dictitems_contains swallows compare errors

2016-09-17 Thread Xiang Zhang
New submission from Xiang Zhang: Now, when compare errors raised during `in`, dict.keys(), dict.values() and set all propagate the errors. But dict.items() will swallow the errors(only key compare): >>> class BadEq: ... def __hash__(self): ... return 7 ... def __eq__(self,