[issue28113] Remove Py_CreateSymbolicLinkW

Berker Peksag added the comment: Py_CreateSymbolicLinkW() has been removed in bpo-31512. PR 12907 updates tests to use support.TESTN. -- ___ Python tracker ___ __

[issue28113] Remove Py_CreateSymbolicLinkW

Change by Berker Peksag : -- pull_requests: +12834 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue28113] Remove Py_CreateSymbolicLinkW

Steve Dower added the comment: One other thing, I have come across some CI configurations recently where TEMP is not the best choice (e.g. when it's a mount point in a VM/container). It seems likely that at some point we'll centralize the "working directory" for the test suite in a way that

[issue28113] Remove Py_CreateSymbolicLinkW

Berker Peksag added the comment: Eryk, would you like to address Steve's comments and convert your patch to a GitHub pull request? Let me know if you don't have time to prepare a new patch. -- nosy: +berker.peksag versions: -Python 3.6, Python 3.7 ___

[issue28113] Remove Py_CreateSymbolicLinkW

Steve Dower added the comment: We should look at merging this, though we need a few things to be done first (anyone can jump in and do these, doesn't have to be Eryk): * patch needs to be converted to a GitHub PR * we should use unique names within %TEMP% to avoid conflicts between tests runn

[issue28113] Remove Py_CreateSymbolicLinkW

Eryk Sun added the comment: This patch also updates Win32SymlinkTests and Win32JunctionTests to use the user's %TEMP% directory instead of the source tree. It's much more likely that %TEMP% is on the system volume, which should be an NTFS volume that supports symbolic links and junctions. ---

[issue28113] Remove Py_CreateSymbolicLinkW

New submission from Eryk Sun: In 3.6, the Windows implementation of os.symlink can be simplified to directly call CreateSymbolicLinkW, since this function was added in Windows Vista. The support code for Py_CreateSymbolicLinkW can be removed from Modules/posixmodule.c. enable_symlink can also