[issue28009] Fix uuid.uuid1() core logic of uuid.getnode() needs refresh

Tal Einat added the comment: Your fix LGTM, Victor. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue28009] Fix uuid.uuid1() core logic of uuid.getnode() needs refresh

STINNER Victor added the comment: > I will look closely at PR19045 - not because I expect to find anything wrong, > but because I thought this is what you requested. I cannot run functional tests on AIX. I can only rely on unit tests which contains a dump of AIX commands. That's why a review

[issue28009] Fix uuid.uuid1() core logic of uuid.getnode() needs refresh

Michael Felt added the comment: On 18/03/2020 13:55, STINNER Victor wrote: > STINNER Victor added the comment: > >> I may be mistaken, but I do not think the change introduced a regression. I meant - I had never considered IPv6 in the Address column, just as I suspect, whoever wrote the origi

[issue28009] Fix uuid.uuid1() core logic of uuid.getnode() needs refresh

STINNER Victor added the comment: > I may be mistaken, but I do not think the change introduced a regression. I'm talking about this: https://bugs.python.org/issue39991#msg364435 I don't want to blame anyone. My intent here is to get more eyes on the changes that I merged in bpo-39991 to mak

[issue28009] Fix uuid.uuid1() core logic of uuid.getnode() needs refresh

Michael Felt added the comment: I may be mistaken, but I do not think the change introduced a regression. While it is true that this case would not have appeared if there was still a count of the field-separators an IPv6 address with 5 ':' and 17 characters would have failed as well. The value

[issue28009] Fix uuid.uuid1() core logic of uuid.getnode() needs refresh

Michael Felt added the comment: I'll take a look as well. On 17/03/2020 16:14, STINNER Victor wrote: > STINNER Victor added the comment: > >> New changeset 0bcbfa43d55d9558cdcb256d8998366281322080 by Tal Einat (Michael >> Felt) in branch 'master': >> bpo-28009: Fix uuid.uuid1() and uuid.get_

[issue28009] Fix uuid.uuid1() core logic of uuid.getnode() needs refresh

STINNER Victor added the comment: > New changeset 0bcbfa43d55d9558cdcb256d8998366281322080 by Tal Einat (Michael > Felt) in branch 'master': > bpo-28009: Fix uuid.uuid1() and uuid.get_node() on AIX (GH-8672) This change introduced a regression: bpo-39991. I pushed the commit eb886db1e99a15f1

[issue28009] Fix uuid.uuid1() core logic of uuid.getnode() needs refresh

Change by Shantanu : -- pull_requests: +17744 pull_request: https://github.com/python/cpython/pull/18369 ___ Python tracker ___ ___

[issue28009] Fix uuid.uuid1() core logic of uuid.getnode() needs refresh

Tal Einat added the comment: Michael, many many thanks for the time and effort that you have poured into getting this fixed, and for your patience and perseverance over the three years that it took to happen. Well done! -- resolution: -> fixed stage: patch review -> resolved status: