[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Changes by Guido van Rossum : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Changes by Guido van Rossum : -- stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Roundup Robot added the comment: New changeset 87e3a58ed3c3 by Guido van Rossum in branch '3.5': Issue #27700: Document AbstractEventLoop, not BaseEventLoop. https://hg.python.org/cpython/rev/87e3a58ed3c3 New changeset d69f782d642d by Guido van Rossum in branch 'default': Issue #27700: Document

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Yury Selivanov added the comment: Fair enough. I don't have any other questions about the patch. -- ___ Python tracker ___ ___ Python

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Guido van Rossum added the comment: The reason I kept some mention of BaseEventLoop is just that until now it was the only thing documented and people might have references to it. It would be good if searching for BaseEventLoop took them to a section explaining they shouldn't use it, rather than

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Yury Selivanov added the comment: The patch looks good. I have a question: do we actually want to document BaseEventLoop? It's not a user-facing class, and the knowledge that it exists doesn't add to anything IMO. -- ___ Python tracker

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Changes by Guido van Rossum : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Changes by Guido van Rossum : -- Removed message: http://bugs.python.org/msg272183 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Guido van Rossum added the comment: Here's the file. -- keywords: +patch Added file: http://bugs.python.org/file44051/Base2Abstract.diff ___ Python tracker ___ __

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Changes by Guido van Rossum : -- Removed message: http://bugs.python.org/msg272182 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Guido van Rossum added the comment: Uploading the file. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Changes by Guido van Rossum : -- Removed message: http://bugs.python.org/msg272181 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Guido van Rossum added the comment: Here's the file (I hope). -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Guido van Rossum added the comment: Here's a tentative diff. I did a global replace BaseEventLoop -> AbstractEventLoop and added an entry for BaseEventLoop (just above AbstractEventLoop) explaining that it should not be used. Please review for obvious mistakes. -- __

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Yury Selivanov added the comment: I think we should fix this. BaseEventLoop is just an implementation detail of asyncio (I think we shouldn't have exposed it in asyncio.__all__ at all). -- ___ Python tracker

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

Guido van Rossum added the comment: Cross-reference: this came up in https://github.com/python/typeshed/issues/452 -- ___ Python tracker ___ _

[issue27700] Document asyncio.AbstractEventLoop, not asyncio.BaseEventLoop

New submission from Guido van Rossum: The asyncio docs currently document the event loop interface as belonging to BaseEventLoop. But the intention of PEP 3156 was for the interface to belong to AbstractEventLoop. In typeshed we ended up exporting only AbstractEventLoop, but this runs into tro