[issue27698] socketpair not in socket.__all__ on Windows

Changes by Berker Peksag : -- stage: needs patch -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue27698] socketpair not in socket.__all__ on Windows

Vedran Čačić added the comment: No problem. Thank you for fixing it. :-) -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue27698] socketpair not in socket.__all__ on Windows

Roundup Robot added the comment: New changeset ac2bc921169c by Victor Stinner in branch '3.5': Issue #27698: Add socketpair to socket.__all__ on Windows https://hg.python.org/cpython/rev/ac2bc921169c -- nosy: +python-dev ___ Python tracker

[issue27698] socketpair not in socket.__all__ on Windows

STINNER Victor added the comment: The issue should now be fixed by my change. Thanks for the bug report! -- nosy: +haypo resolution: -> fixed status: open -> closed ___ Python tracker _

[issue27698] socketpair not in socket.__all__ on Windows

Changes by Eryk Sun : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue27698] socketpair not in socket.__all__ on Windows

R. David Murray added the comment: Ah, I see. Yes, the normal "automatic adding" probably made that easy to forget. The lack of "windows" comment there fooled me...it looks like what was really added was "support for any platform that supports sockets but not socketpair" :) --

[issue27698] socketpair not in socket.__all__ on Windows

Eryk Sun added the comment: See issue 18643, which added a Windows implementation of socketpair(). Since it's not defined in the _socket extension module, it isn't added to socket.__all__. Someone simply forgot to add `__all__.append("socketpair")` after the definition on line 485. --

[issue27698] socketpair not in socket.__all__ on Windows

Changes by Eryk Sun : -- Removed message: http://bugs.python.org/msg272188 ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue27698] socketpair not in socket.__all__ on Windows

Eryk Sun added the comment: See issue 18643, which added a Windows implementation of socketpair(). Since it's not defined in the _socket extension module, it isn't added to socket.__all__. Someone simply forgot to add `__all__.append("sockpetpair")` after the definition on line 485. -

[issue27698] socketpair not in socket.__all__ on Windows

SilentGhost added the comment: > nor do I see any mention of socketpair in the 3.5 whatsnew socket.socketpair has a versionchanged 3.5: Windows support added. -- nosy: +SilentGhost ___ Python tracker __

[issue27698] socketpair not in socket.__all__ on Windows

R. David Murray added the comment: I don't see any special casing for windows in the socketpair code in the current socket module, nor do I see any mention of socketpair in the 3.5 whatsnew. Based on a quick scan of the socket code I don't see how socketpair could be defined on a platform wit

[issue27698] socketpair not in socket.__all__ on Windows

Changes by SilentGhost : -- components: +Windows nosy: +paul.moore, pitrou, steve.dower, tim.golden, zach.ware stage: -> needs patch type: -> behavior ___ Python tracker ___ __

[issue27698] socketpair not in socket.__all__ on Windows

New submission from Vedran Čačić: It seems socketpair is added for Windows in Py3.5, but it isn't imported with `from socket import *`. Can it be added to __all__? -- components: Library (Lib) messages: 272084 nosy: veky priority: normal severity: normal status: open title: socketpair n