[issue27657] urlparse fails if the path is numeric

Leif Walsh added the comment: I don't mean to reopen a can of worms, but this affects requests, which I reported to them here: https://github.com/psf/requests/issues/5855 -- nosy: +leif.walsh ___ Python tracker

[issue27657] urlparse fails if the path is numeric

Chris Dent added the comment: I don't want to belabour the point. If there's general agreement that the new behaviour is the best result that's fine, especially if it is well announced. I agree that it has been inconsistent and weird for a long time. I think my objection simply comes down to

[issue27657] urlparse fails if the path is numeric

Senthil Kumaran added the comment: Chris, my understanding of the primary objection in your previous post was with a violation of backward compatibility. It was resolved by reverting. The 3.9+ changes are useful ones, particularly when well-defined behaviors are listed for URLs with the sche

[issue27657] urlparse fails if the path is numeric

Chris Dent added the comment: I just wanted to reiterate what I said at https://bugs.python.org/issue27657#msg360196 The supposed fix provides terribly UX and violates what I think for many people is the path of least surprise. -- ___ Python trac

[issue27657] urlparse fails if the path is numeric

Senthil Kumaran added the comment: Michał, for this particular issue, to rely on the expected and consistent parsing behavior, it might easier to add "scheme" to URLs in the client code. That will be less confusing IMO. Not sure if __future__ is a good idea. Personally, I am -1 at this point

[issue27657] urlparse fails if the path is numeric

Michał Górny added the comment: I wonder if it would be feasible to support new behavior in earlier versions of Python via __future__. I suppose that could help software avoid having Python version-dependent behavior in the long run. -- ___ Python

[issue27657] urlparse fails if the path is numeric

Senthil Kumaran added the comment: Hi All, On the previous message. > I plan to address that point raised in this issue and close this ticket. My intention was to close the bug. 1) The Issue was originally a regression in 3.8, and 3.7, And this been be resolved. The change introduced did

[issue27657] urlparse fails if the path is numeric

Łukasz Langa added the comment: Michał, this change has been reverted in 3.7 and 3.8. Senthil says this needs further work in 3.9. Senthil, please prioritize this. We're already releasing 3.9.0b2. -- ___ Python tracker

[issue27657] urlparse fails if the path is numeric

Michał Górny added the comment: I'm sorry but does this change mean that it's not final or...? My main concern is whether we should be adjusting our packages to the new behavior in py3.9, or wait for further changes. -- ___ Python tracker

[issue27657] urlparse fails if the path is numeric

Change by Ned Deily : -- stage: patch review -> needs patch versions: +Python 3.10, Python 3.9 -Python 2.7, Python 3.7, Python 3.8 ___ Python tracker ___ __

[issue27657] urlparse fails if the path is numeric

Michał Górny added the comment: Do I understand correctly that the new behavior is intentional in 3.9, or is that still being discussed? -- nosy: +mgorny ___ Python tracker __

[issue27657] urlparse fails if the path is numeric

Ned Deily added the comment: FYI, for those following along, now that 3.8.2 has been released with the revert of the regression, we are planning to accelerate the schedule for 3.7.7, the next 3.7.x bugfix release, in part to get the revert out to 3.7.x users sooner (https://discuss.python.o

[issue27657] urlparse fails if the path is numeric

Senthil Kumaran added the comment: Hi Łukasz, There was a concern raised by python core-devs about behavior in 3.9. I plan to address that point raised in this issue and close this ticket. -- ___ Python tracker

[issue27657] urlparse fails if the path is numeric

Łukasz Langa added the comment: Can this be closed? Downgrading priority since the fix was released as part of 3.8.2rc2 and 3.8.2 final. -- priority: release blocker -> critical ___ Python tracker __

[issue27657] urlparse fails if the path is numeric

Senthil Kumaran added the comment: New changeset ea316fd21527dec53e704a5b04833ac462ce3863 by Senthil Kumaran in branch '3.8': Revert "[3.8] bpo-27657: Fix urlparse() with numeric paths (GH-16839)" (GH-18525) https://github.com/python/cpython/commit/ea316fd21527dec53e704a5b04833ac462ce3863

[issue27657] urlparse fails if the path is numeric

Senthil Kumaran added the comment: New changeset 505b6015a1579fc50d9697e4a285ecc64976397a by Senthil Kumaran in branch '3.7': Revert "bpo-27657: Fix urlparse() with numeric paths (GH-661)" (#18526) https://github.com/python/cpython/commit/505b6015a1579fc50d9697e4a285ecc64976397a --

[issue27657] urlparse fails if the path is numeric

Change by Senthil Kumaran : -- pull_requests: +17903 pull_request: https://github.com/python/cpython/pull/18526 ___ Python tracker ___ _

[issue27657] urlparse fails if the path is numeric

Change by Senthil Kumaran : -- keywords: +patch pull_requests: +17902 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/18525 ___ Python tracker ___

[issue27657] urlparse fails if the path is numeric

Senthil Kumaran added the comment: Hi Lukaz / Ned: I will like to revert the backports done in 3.8 and 3.7. Preferably in 3.8.2 and 3.7.7, so that this undesirable behavior exists only for a single release. I have set this is a release blocker to catch your attention. -- nosy: +be

[issue27657] urlparse fails if the path is numeric

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue27657] urlparse fails if the path is numeric

Chris Dent added the comment: Just to add to the list of places this is causing a regression. This has broken the target host determination routines in gabbi: https://github.com/cdent/gabbi/issues/277 While the original fix may have been strictly correct in some ways, it results in a terrib

[issue27657] urlparse fails if the path is numeric

Change by Ned Deily : -- keywords: +3.7regression, 3.8regression -patch priority: normal -> deferred blocker ___ Python tracker ___

[issue27657] urlparse fails if the path is numeric

Senthil Kumaran added the comment: @James - Originally the issue was considered a revert and the versions were set for the merge, but I certainly recognize the problem when parsing can fail for simple URLs like `localhost:8000` which is very common. Another developer had raised the concerns

[issue27657] urlparse fails if the path is numeric

James Brown added the comment: This is a surprising change to put in a minor release. This change totally changes the semantics of parsing scheme-less URLs with ports in them and ended up breaking a significant amount of my software. It turns out that urls like `example.com:80` are more comm

[issue27657] urlparse fails if the path is numeric

STINNER Victor added the comment: This issue got fixes, so I close it. -- nosy: +vstinner resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue27657] urlparse fails if the path is numeric

Senthil Kumaran added the comment: New changeset 0f3187c1ce3b3ace60f6c1691dfa3d4e744f0384 by Senthil Kumaran in branch '3.8': [3.8] bpo-27657: Fix urlparse() with numeric paths (GH-661) (#16839) https://github.com/python/cpython/commit/0f3187c1ce3b3ace60f6c1691dfa3d4e744f0384 -- __

[issue27657] urlparse fails if the path is numeric

Change by Senthil Kumaran : -- pull_requests: +16388 pull_request: https://github.com/python/cpython/pull/16839 ___ Python tracker ___ _

[issue27657] urlparse fails if the path is numeric

miss-islington added the comment: New changeset 82b5f6b16e051f8a2ac6e87ba86b082fa1c4a77f by Miss Islington (bot) in branch '3.7': bpo-27657: Fix urlparse() with numeric paths (GH-661) https://github.com/python/cpython/commit/82b5f6b16e051f8a2ac6e87ba86b082fa1c4a77f -- nosy: +miss-is

[issue27657] urlparse fails if the path is numeric

Senthil Kumaran added the comment: New changeset 5a88d50ff013a64fbdb25b877c87644a9034c969 by Senthil Kumaran (Tim Graham) in branch 'master': bpo-27657: Fix urlparse() with numeric paths (#661) https://github.com/python/cpython/commit/5a88d50ff013a64fbdb25b877c87644a9034c969 -- ___

[issue27657] urlparse fails if the path is numeric

Change by Cheryl Sabella : -- stage: -> patch review versions: +Python 3.7, Python 3.8 -Python 3.5, Python 3.6 ___ Python tracker ___ __

[issue27657] urlparse fails if the path is numeric

Tim Graham added the comment: Based on discussion in issue 16932, I agree that reverting the parsing decisions from issue 754016 (as Martin suggested in msg271719) seems appropriate. I created a pull request that does that. -- nosy: +Tim.Graham ___

[issue27657] urlparse fails if the path is numeric

Changes by Tim Graham : -- pull_requests: +543 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue27657] urlparse fails if the path is numeric

R. David Murray added the comment: Ah, good point, I misread the scope of the problem. -- ___ Python tracker ___ ___ Python-bugs-list

[issue27657] urlparse fails if the path is numeric

Martin Panter added the comment: Depends on how you define “looks like an IP address”. Does the www.cwi.nl:80 case look like an IP address? What about “path:80” or “localhost:80”? If there is any code relying on the bug, it may just as easily involve host name as a numeric IP address. ---

[issue27657] urlparse fails if the path is numeric

R. David Murray added the comment: On second thought, what are the chances that special casing something that looks like an IP address in the scheme position would maintain backward compatibility? -- ___ Python tracker

[issue27657] urlparse fails if the path is numeric

R. David Murray added the comment: I hate to say it, but this may require a python-dev discussion. We probably ought to be parsing valid urls correctly as our top priority, but if that breaks our parsing of "reasonable" non-valid URLs (that existing code is depending on), it's going to be a b

[issue27657] urlparse fails if the path is numeric

Martin Panter added the comment: The main backward compatibility consideration would be Issue 754016, but don’t agree with the changes made, and would support reverting them. The original bug reporter wanted urlparse("1.2.3.4:80", "http") to be treated as the URL http://1.2.3.4:80, but the IP

[issue27657] urlparse fails if the path is numeric

R. David Murray added the comment: See issue 14072. It may be time to look at this again, but we may still be constrained by backward compatibility. -- nosy: +r.david.murray ___ Python tracker ___

[issue27657] urlparse fails if the path is numeric

New submission from Björn Lindqvist: This affects both Python 2 and 3. This is as expected: >>> urlparse('abc:123.html') ParseResult(scheme='abc', netloc='', path='123.html', params='', query='', fragment='') >>> urlparse('123.html:abc') ParseResult(scheme='123.html', netloc='', path='abc', par