[issue27540] msvcrt.ungetwch() calls _ungetch()

Change by Zachary Ware : -- resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ ___

[issue27540] msvcrt.ungetwch() calls _ungetch()

Zachary Ware added the comment: If this isn't an issue in Python 3, I agree. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27540] msvcrt.ungetwch() calls _ungetch()

Zackery Spytz added the comment: Python 2 is EOL, so I think this issue should be closed. -- nosy: +ZackerySpytz ___ Python tracker ___ ___

[issue27540] msvcrt.ungetwch() calls _ungetch()

Armin Rigo added the comment: Uh, you're right. Then I can also add that putwch() strangely checks for unicode strings of length != 0 instead of == 1, despite what it says it its error message. These functions appear not to be tested or even (in case of ungetwch()) used by anyone. -

[issue27540] msvcrt.ungetwch() calls _ungetch()

Eryk Sun added the comment: Parsing the argument is also broken: static PyObject * msvcrt_ungetwch(PyObject *self, PyObject *args) { Py_UNICODE ch; if (!PyArg_ParseTuple(args, "u:ungetwch", &ch)) return NULL; if (_ungetch(ch) == EOF)

[issue27540] msvcrt.ungetwch() calls _ungetch()

New submission from Armin Rigo: In Python 2.7, PC/msvcrtmodule.c, the function msvcrt_ungetwch() calls _ungetch() instead of _ungetwch() as was probably intended. -- components: Extension Modules messages: 270620 nosy: arigo priority: normal severity: normal status: open title: msvcrt.u