[issue27454] PyUnicode_InternInPlace can use PyDict_SetDefault

2016-07-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset f3187a157204 by Berker Peksag in branch 'default': Issue #27454: Use PyDict_SetDefault in PyUnicode_InternInPlace https://hg.python.org/cpython/rev/f3187a157204 -- nosy: +python-dev ___ Python tracker

[issue27454] PyUnicode_InternInPlace can use PyDict_SetDefault

2016-07-24 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ _

[issue27454] PyUnicode_InternInPlace can use PyDict_SetDefault

2016-07-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27454] PyUnicode_InternInPlace can use PyDict_SetDefault

2016-07-05 Thread INADA Naoki
INADA Naoki added the comment: Thank you for pointing it out. That comment seems useless when removing PyDict_GetItem(). So I removed it. -- Added file: http://bugs.python.org/file43634/intern-setdefault2.patch ___ Python tracker

[issue27454] PyUnicode_InternInPlace can use PyDict_SetDefault

2016-07-05 Thread Berker Peksag
Berker Peksag added the comment: I think you also need to update the comment below: /* It might be that the GetItem call fails even though the key is present in the dictionary, namely when this happens during a stack overflow. */ -- nosy: +berker.peksag, haypo, serhiy.

[issue27454] PyUnicode_InternInPlace can use PyDict_SetDefault

2016-07-05 Thread INADA Naoki
New submission from INADA Naoki: PyDict_SetDefault() was added Python 3.4 Currently, PyUnicode_InternInPlace() uses PyDict_GetItem, and PyDict_SetItem if no item found. It can be replaced PyDict_SetDefault() easily. -- components: Interpreter Core files: intern-setdefault.patch keyword