[issue27452] IDLE: Cleanup config code

Terry J. Reedy added the comment: Thanks for preparing the PR. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker ___

[issue27452] IDLE: Cleanup config code

Terry J. Reedy added the comment: New changeset efd23a199b1415a9850a914d525a1e5711fdd6d8 by Terry Jan Reedy (Miss Islington (bot)) in branch '3.7': bpo-27452: IDLE: Cleanup config.py code (GH-14577) (GH-14803) https://github.com/python/cpython/commit/efd23a199b1415a9850a914d525a1e5711fdd6d8

[issue27452] IDLE: Cleanup config code

Terry J. Reedy added the comment: New changeset 178f09f8b7d25348d46751a774666dd4ec32f3e6 by Terry Jan Reedy (Miss Islington (bot)) in branch '3.8': bpo-27452: IDLE: Cleanup config.py code (GH-14577) (GH-14802) https://github.com/python/cpython/commit/178f09f8b7d25348d46751a774666dd4ec32f3e6

[issue27452] IDLE: Cleanup config code

Terry J. Reedy added the comment: As near as I can tell, 'python file.py' results in absolute __file__ in 3.9 versus still relative in 3.8. -- ___ Python tracker ___

[issue27452] IDLE: Cleanup config code

Change by miss-islington : -- pull_requests: +14599 pull_request: https://github.com/python/cpython/pull/14803 ___ Python tracker ___ __

[issue27452] IDLE: Cleanup config code

Change by miss-islington : -- pull_requests: +14598 pull_request: https://github.com/python/cpython/pull/14802 ___ Python tracker ___ __

[issue27452] IDLE: Cleanup config code

Terry J. Reedy added the comment: New changeset f8d4cc7dbbf54b9c5435c3080582a4aa421a067d by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-27452: IDLE: Cleanup config.py code (GH-14577) https://github.com/python/cpython/commit/f8d4cc7dbbf54b9c5435c3080582a4aa421a067d -- _

[issue27452] IDLE: Cleanup config code

Change by Cheryl Sabella : -- versions: +Python 3.8, Python 3.9 -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27452] IDLE: Cleanup config code

Change by Cheryl Sabella : -- pull_requests: +14396 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/14577 ___ Python tracker ___ ___

[issue27452] IDLE: Cleanup config code

Changes by Terry J. Reedy : -- components: +IDLE ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue27452] IDLE: Cleanup config code

Serhiy Storchaka added the comment: In this case it works, because os.join('', filename) returns filename. -- ___ Python tracker ___ _

[issue27452] IDLE: Cleanup config code

Terry J. Reedy added the comment: Ah, the invocation I did not test ;-). It does not matter in this case because "os.path.dirname('config.py')" is '' and the join leaves relative names for the config files that work fine for opening them. F:\Python\dev\36\Lib\idlelib>..\..\pcbuild\win32\pytho

[issue27452] IDLE: Cleanup config code

Roundup Robot added the comment: New changeset adbeef96ae95 by Terry Jan Reedy in branch 'default': Issue #27452: make command line idle-test> python test_help.py work. https://hg.python.org/cpython/rev/adbeef96ae95 -- ___ Python tracker

[issue27452] IDLE: Cleanup config code

Roundup Robot added the comment: New changeset da83e115afea by Terry Jan Reedy in branch '2.7': Issue #27452: add line counter and crc to IDLE configHandler test dump. https://hg.python.org/cpython/rev/da83e115afea New changeset 127569004538 by Terry Jan Reedy in branch '3.5': Issue #27452: add

[issue27452] IDLE: Cleanup config code

Serhiy Storchaka added the comment: $ ./python -m file /home/serhiy/py/cpython/file.py $ ./python file.py file.py -- ___ Python tracker ___ __

[issue27452] IDLE: Cleanup config code

Terry J. Reedy added the comment: How can you get a relative path in 3.6 (or other current Python)? To test, I wrote file.py containing "print(__file__)". Executing from IDLE, with "python path/to/file.py", "path/to/file.py", "file.py" in the path/to directory, and "python -m to.file" (where

[issue27452] IDLE: Cleanup config code

Serhiy Storchaka added the comment: If config.py is just executed, __file__ can be a relative path. RemoveFile() looks as a part of public API. If you are sure that nobody needs to remove a config file, you can remove this method. -- ___ Python trac

[issue27452] IDLE: Cleanup config code

New submission from Terry J. Reedy: The config module code can be improved even without changing behavior. While working on #27380, I noticed these two: IdleUserConfParser.RemoveFile is a simple one-liner called once. Put it inline. IdleConf.CreateConfigHandlers: A) As near as I can tell, __f