[issue27380] IDLE: add base Query dialog with ttk widgets

Change by Terry J. Reedy : -- components: +IDLE ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue27380] IDLE: add base Query dialog with ttk widgets

Ned Deily added the comment: With 8f37d772f71f, the test no longer fails. Thanks! -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker _

[issue27380] IDLE: add base Query dialog with ttk widgets

Terry J. Reedy added the comment: While still curious if the Mac specific code is correct, I changed test to match the code. Someone please check by running at least test_idle after pulling. -- ___ Python tracker

[issue27380] IDLE: add base Query dialog with ttk widgets

Roundup Robot added the comment: New changeset 8f37d772f71f by Terry Jan Reedy in branch 'default': Issue #27380: For test_query on Mac, adjust one expected result. https://hg.python.org/cpython/rev/8f37d772f71f -- ___ Python tracker

[issue27380] IDLE: add base Query dialog with ttk widgets

Changes by Terry J. Reedy : -- nosy: +markroseman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue27380] IDLE: add base Query dialog with ttk widgets

Terry J. Reedy added the comment: The Mac failure comes from this piece of code: if sys.platform == 'darwin': path = self.result[1] if path.startswith(('www', 'file:', 'http:', https:')): pass else:

[issue27380] IDLE: add base Query dialog with ttk widgets

Ned Deily added the comment: test_click_help_source fails on OS X: == FAIL: test_click_help_source (idlelib.idle_test.test_query.HelpsourceGuiTest) -- Traceback

[issue27380] IDLE: add base Query dialog with ttk widgets

Terry J. Reedy added the comment: Patch posted had code that belongs to #27465 and was deleted before pushing. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue27380] IDLE: add base Query dialog with ttk widgets

Roundup Robot added the comment: New changeset 66fe8d9eae6c by Terry Jan Reedy in branch 'default': Issue #27380: IDLE: add query.HelpSource class and tests. https://hg.python.org/cpython/rev/66fe8d9eae6c -- ___ Python tracker

[issue27380] IDLE: add base Query dialog with ttk widgets

Terry J. Reedy added the comment: Serhiy, thank you for the review. I intend to follow PEP 8 as best as possible in the code I touch. I also fixed some of the comments. I did a bit of refactoring that make it trivial to check for reuse of help source names. See new issue #27465. All that i

[issue27380] IDLE: add base Query dialog with ttk widgets

Terry J. Reedy added the comment: Next patch should finish issue except for a couple of minor questions. -- stage: test needed -> commit review Added file: http://bugs.python.org/file43651/query-helpsource.diff ___ Python tracker

[issue27380] IDLE: add base Query dialog with ttk widgets

Terry J. Reedy added the comment: (Misdirected notice copied here) New changeset 78a3d3700233 by Terry Jan Reedy in branch 'default': Issue 27437: Add query.ModuleName and use it for file => Load Module. https://hg.python.org/cpython/rev/78a3d3700233 -- _

[issue27380] IDLE: add base Query dialog with ttk widgets

Terry J. Reedy added the comment: Added tests for ModuleName. Will recheck and push. -- Added file: http://bugs.python.org/file43618/query4.diff ___ Python tracker ___ _

[issue27380] IDLE: add base Query dialog with ttk widgets

Terry J. Reedy added the comment: Revised load_module and new query.ModuleName work, including when invoked by open_class_browser. Tests are need for both. One problem was that using withdrawn root rather than a text as parent caused query.Query to not appear, so wait_window could not be ter

[issue27380] IDLE: add base Query dialog with ttk widgets

Terry J. Reedy added the comment: Thanks, I will switch to True and False. I am aware of the possibility of separately importing the constants, but like some others, I prefer the strings. Compile-time checking is a good point, especially with no run tests. In this case, test_query has 100% c

[issue27380] IDLE: add base Query dialog with ttk widgets

Serhiy Storchaka added the comment: You can use True and False instead of TRUE and FALSE. You can import constants with "from tkinter.constants import *". The benefit of using constants instead of string literals is early failing in case of typo. -- nosy: +serhiy.storchaka ___

[issue27380] IDLE: add base Query dialog with ttk widgets

Terry J. Reedy added the comment: Pushed with minor changes. I decided not to wait until I added more subclasses because file renames with post rename changes do not survive shelving. Reloading from the diff requires 'rediscovering' the renames. -- Added file: http://bugs.python.org/

[issue27380] IDLE: add base Query dialog with ttk widgets

Roundup Robot added the comment: New changeset 4796d7fb00c5 by Terry Jan Reedy in branch 'default': Issue #27380: IDLE: add base Query dialog, with ttk widgets and subclass https://hg.python.org/cpython/rev/4796d7fb00c5 -- nosy: +python-dev ___ Python

[issue27380] IDLE: add base Query dialog with ttk widgets

New submission from Terry J. Reedy: The custom popup entry dialogs in config_sec and config_help have a common structure and overlapping code. When one hits OK and the entry is not valid, both display a specific message and let the user edit the entry (or Cancel). File => Load Module, on the