[issue27318] Add support for symlinks to zipfile

Change by Henry Schreiner : -- nosy: +Henry Schreiner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue27318] Add support for symlinks to zipfile

Change by Eryk Sun : -- versions: +Python 3.10 -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue27318] Add support for symlinks to zipfile

Mathieu Bridon added the comment: Do note that extracting a zipfile with symlinks might lead to unexpected results, for example if the path pointed to is outside of the extract dir. Maybe the behaviour introduced in this patch should not be the default, but instead `extract` and `extractall` c

[issue27318] Add support for symlinks to zipfile

Lukáš Doktor added the comment: Hello Eryk, thank you for the prompt response. I have only checked that using python2.6 on `wine` and there was no `os.symlink` support there. I'm not sure how to reasonably handle the `dir` flag for Windows as theoretically the symlink can point out of the zip

[issue27318] Add support for symlinks to zipfile

Eryk Sun added the comment: os.symlink needs the target_is_directory argument on Windows. Maybe extract() can search for the link target in namelist() to determine if it's a directory (i.e. ends in "/"). Note that the flag gets set automatically if the target exists, so this is only a problem

[issue27318] Add support for symlinks to zipfile

Changes by SilentGhost : -- nosy: +alanmcintyre, serhiy.storchaka, twouters versions: +Python 3.6 -Python 2.7 ___ Python tracker ___ _

[issue27318] Add support for symlinks to zipfile

New submission from Lukáš Doktor: Currently the zipfile library extracts all files as simple files, even though it contains the information of the file attributes. This patch uses them to detect if the original file was a symlink and creates it when there is a support for symlink creation. --