[issue27095] Simplify MAKE_FUNCTION

Serhiy Storchaka added the comment: Pushed with minor changes. Thank you for your contribution Demur! You change to the documentation of EXTENDED_ARG isn't pushed. I would prefer to see it as a part of larger documentation patch in issue26647. After pushing I found a bug (similar bug was exist

[issue27095] Simplify MAKE_FUNCTION

Roundup Robot added the comment: New changeset 8a0fe3481c91 by Serhiy Storchaka in branch 'default': Issue #27095: Simplified MAKE_FUNCTION and removed MAKE_CLOSURE opcodes. https://hg.python.org/cpython/rev/8a0fe3481c91 -- nosy: +python-dev ___ Pytho

[issue27095] Simplify MAKE_FUNCTION

Serhiy Storchaka added the comment: Regenerated for review. -- Added file: http://bugs.python.org/file43363/mkfu5.patch ___ Python tracker ___ ___

[issue27095] Simplify MAKE_FUNCTION

Serhiy Storchaka added the comment: Yes, this is why I wanted first push the patch with BUILD_CONST_KEY_MAP. -- ___ Python tracker ___ ___

[issue27095] Simplify MAKE_FUNCTION

Demur Rumed added the comment: Kind of amusing how visit_argannoation logic went full circle. Makes sense considering pre-mkfu patch the ABI was quite similar on that front -- Added file: http://bugs.python.org/file43362/mkfu5.patch ___ Python tracke

[issue27095] Simplify MAKE_FUNCTION

Serhiy Storchaka added the comment: Added more comments on Rietveld. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue27095] Simplify MAKE_FUNCTION

Demur Rumed added the comment: mkfu4 implements #27140. It doesn't special case 1-tuples into `BUILD_MAP 1` It may be easier to have `BUILD_CONST_KEY_MAP 1` peepholed if it's really preferable to strength reduce I'm also noticing that it could've been suggested to go to the extreme with BUILD

[issue27095] Simplify MAKE_FUNCTION

Serhiy Storchaka added the comment: Now with adding BUILD_CONST_KEY_MAP I think MAKE_FUNCTION can be more compact. -- ___ Python tracker ___ _

[issue27095] Simplify MAKE_FUNCTION

Changes by Serhiy Storchaka : -- nosy: +Mark.Shannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue27095] Simplify MAKE_FUNCTION

Serhiy Storchaka added the comment: In general the patch LGTM, besides few minor comments. But new implementation uses longer bytecode for annotations. Current code packs argument names in one constant tuple: $ ./python -m dis def f(x: int, y: str, z: float): pass 1 0 LOAD_NAME

[issue27095] Simplify MAKE_FUNCTION

Demur Rumed added the comment: May've been best to wait on posting a patch, but long weekend yesterday made time available mkfu3 updates mkfu2 with wordcode. Includes fix to EXTENDED_ARG documentation -- Added file: http://bugs.python.org/file42965/mkfu3.patch

[issue27095] Simplify MAKE_FUNCTION

Serhiy Storchaka added the comment: At first look your patch looks good (I'll make more detailed review later), but you should wait until we have finished all work related to the conversion to wordcode. -- ___ Python tracker

[issue27095] Simplify MAKE_FUNCTION

Demur Rumed added the comment: Attached are modifications to the patch based on feedback from Nikita. It produces a larger patch tho. The changes are to combine return branches in compiler_make_closure & to combine code between compiler_function & compiler_lambda into compiler_default_argument

[issue27095] Simplify MAKE_FUNCTION

Changes by Serhiy Storchaka : -- components: +Interpreter Core dependencies: +ceval: use Wordcode, 16-bit bytecode nosy: +serhiy.storchaka ___ Python tracker ___

[issue27095] Simplify MAKE_FUNCTION

Changes by Demur Rumed : -- versions: +Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue27095] Simplify MAKE_FUNCTION

New submission from Demur Rumed: Implemented as per https://mail.python.org/pipermail/python-dev/2016-April/144135.html -- files: mkfu.patch keywords: patch messages: 266187 nosy: Demur Rumed priority: normal severity: normal status: open title: Simplify MAKE_FUNCTION type: performance