[issue27083] PYTHONCASEOK is ignored on Windows

Brett Cannon added the comment: Buildbots are green again and I addressed the key type issue. Thanks for letting me know about the failure, Martin. -- stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue27083] PYTHONCASEOK is ignored on Windows

Roundup Robot added the comment: New changeset 6b46c1510bfa by Brett Cannon in branch '3.5': Fix regressions introduced by fixes for issue #27083. https://hg.python.org/cpython/rev/6b46c1510bfa New changeset f4c91b883772 by Brett Cannon in branch 'default': Merge for #27083 https://hg.python.org

[issue27083] PYTHONCASEOK is ignored on Windows

Martin Panter added the comment: This appears to have broken the tests on Windows: http://buildbot.python.org/all/builders/x86%20Windows7%203.5/builds/1030/steps/test/logs/stdio == FAIL: test_insensitive (test.test_importlib.so

[issue27083] PYTHONCASEOK is ignored on Windows

Serhiy Storchaka added the comment: Yes, I think it will work. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue27083] PYTHONCASEOK is ignored on Windows

Brett Cannon added the comment: I think the best we can do is be platform-specific in what is checked for in the environ dict (e.g. b'PYTHONCASEOK' on darwin, 'PYTHONCASEOK' on win, and I don't know about cygwin), but otherwise one would have to iterate through the keys of the dict and do a ty

[issue27083] PYTHONCASEOK is ignored on Windows

Serhiy Storchaka added the comment: Seeing if a key in a dict exists involves the key comparison if there is a key on the same position in the hash table. -- nosy: +rhettinger ___ Python tracker __

[issue27083] PYTHONCASEOK is ignored on Windows

Brett Cannon added the comment: There's no direct comparison to trigger a warning; it's just seeing if a key in a dict exists. And b'PYTHONCASEOK' is not a bug as that's required for OS X (remember this is technically posix.environ, not os.environ). -- status: open -> closed

[issue27083] PYTHONCASEOK is ignored on Windows

Serhiy Storchaka added the comment: Comparing bytes with str can emit a warning or raise an exception. Checking for b'PYTHONCASEOK' in os.environ looks as a bug to me. -- status: closed -> open ___ Python tracker

[issue27083] PYTHONCASEOK is ignored on Windows

Brett Cannon added the comment: I fixed this by simply checking for both b'PYTHONCASEOK' and 'PYTHONCASEOK'. Thanks for the bug report, Eryk! -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue27083] PYTHONCASEOK is ignored on Windows

Roundup Robot added the comment: New changeset bedcb9ec3f26 by Brett Cannon in branch '3.5': Issue #27083: Respect the PYTHONCASEOK environment variable under https://hg.python.org/cpython/rev/bedcb9ec3f26 New changeset 777da58794ca by Brett Cannon in branch 'default': Merge for #27083 https://h

[issue27083] PYTHONCASEOK is ignored on Windows

Brian Herman added the comment: In python 3.6 from hg it has been fixed. >>> glob.glob('*.py') ['setup.py', 'test.py'] >>> import test >>> test.__file__ 'C:\\Users\\brian\\Desktop\\cpython\\test.py' >>> -- nosy: +Brian.Herman ___ Python tracker

[issue27083] PYTHONCASEOK is ignored on Windows

Serhiy Storchaka added the comment: Did you forgot to upload a patch? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bug

[issue27083] PYTHONCASEOK is ignored on Windows

Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue27083] PYTHONCASEOK is ignored on Windows

New submission from Eryk Sun: importlib ignores the PYTHONCASEOK environment variable on Windows. _relax_case checks for b'PYTHONCASEOK' in os.environ, which is never true because os.environ is Unicode. On Windows, _make_relax_case should return a function that instead checks for 'PYTHONCASEOK