[issue27067] Improve curses tests

Serhiy Storchaka added the comment: Continued in issue42789 and issue43016. -- status: open -> closed ___ Python tracker ___ ___ Py

[issue27067] Improve curses tests

Martin Panter added the comment: I’m not 100% following this, but it is sounding like a terminal may be required for proper testing. Perhaps I could try and help by creating a pseudo-terminal in the Python test code, as I hinted at . -- _

[issue27067] Improve curses tests

STINNER Victor added the comment: Zachary Ware added the comment: >> Maybe we should have at least one buildbot testing test_curses with a TTY? > My non-debug and installed Gentoo bot does run the tests with a PTY, ... This one? http://buildbot.python.org/all/builders/x86%20Gentoo%20Non-Debug%2

[issue27067] Improve curses tests

Serhiy Storchaka added the comment: Updated patch makes test_curses working with -jN. But it spoils a screen when run with -jN on a terminal (shouldn't be a problem for buildbots). -- Added file: http://bugs.python.org/file42945/test_curses_no_atty2.patch __

[issue27067] Improve curses tests

Zachary Ware added the comment: > Maybe we should have at least one buildbot testing test_curses with a TTY? My non-debug and installed Gentoo bot does run the tests with a PTY, so you can use its custom builders for experimentation (assuming it can complete a clone). -- __

[issue27067] Improve curses tests

Roundup Robot added the comment: New changeset 433839643bbb by Serhiy Storchaka in branch '3.5': Temporary skip curses tests on non-tty (issue #27067). https://hg.python.org/cpython/rev/433839643bbb New changeset debe693c62b4 by Serhiy Storchaka in branch 'default': Temporary skip curses tests o

[issue27067] Improve curses tests

STINNER Victor added the comment: By the way, all buildbots now use -j1 option and so stdout and stderr are no more TTY on all buildbots: see issue #25285. So test_curses are not fully tested by buildbots anymore. Maybe we should have at least one buildbot testing test_curses with a TTY?

[issue27067] Improve curses tests

STINNER Victor added the comment: test_curses_no_atty.patch doesn't work for me using -j1 regrtest option :-/ haypo@smithers$ ./python -m test -u curses -j1 test_curses Run tests in parallel using 1 child processes Total duration: 0:00:01 Exception in thread Thread-1: Traceback (most recent call

[issue27067] Improve curses tests

Serhiy Storchaka added the comment: My bad. I tested only with stdout redirected, the test fail if both stdout and stderr are redirected. Proposed patch fixes this. -- Added file: http://bugs.python.org/file42936/test_curses_no_atty.patch ___ Python

[issue27067] Improve curses tests

Martin Panter added the comment: A couple buildbots don’t look happy with this change, e.g. http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.5/builds/903/steps/test/logs/stdio == ERROR: test_colors_funcs (test.

[issue27067] Improve curses tests

Serhiy Storchaka added the comment: Thank you for your review Berker. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: commit review -> resolved status: open -> closed versions: -Python 2.7 ___ Python tracker

[issue27067] Improve curses tests

Roundup Robot added the comment: New changeset 55852de7d032 by Serhiy Storchaka in branch '3.5': Issue #27067: Improved curses tests. https://hg.python.org/cpython/rev/55852de7d032 New changeset 2917a3ce988e by Serhiy Storchaka in branch 'default': Issue #27067: Improved curses tests. https://hg

[issue27067] Improve curses tests

Martin Panter added the comment: I guess this might help Issue 12669 (running the test on buildbots)? I had assumed a real terminal was required, but it looks like you are substituting a temporary file. -- nosy: +martin.panter ___ Python tracker

[issue27067] Improve curses tests

Berker Peksag added the comment: LGTM. I left some comments on Rietveld. -- nosy: +berker.peksag stage: patch review -> commit review ___ Python tracker ___ _

[issue27067] Improve curses tests

New submission from Serhiy Storchaka: Proposed patch improves curses tests. Main improvements are: * Tests now run even if sys.stdout is not terminal. * The screen is not spoiled during tests. * Reported the name and arguments of failed function. * Testing optional functionality is extracted in