[issue2695] Ignore case when checking algorithm in urllib2

Georg Brandl <[EMAIL PROTECTED]> added the comment: Applied in r62713. -- nosy: +georg.brandl resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]> __

[issue2695] Ignore case when checking algorithm in urllib2

david reid <[EMAIL PROTECTED]> added the comment: Looks like a sensible, simple fix to me :-) __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mail

[issue2695] Ignore case when checking algorithm in urllib2

Martin McNickle <[EMAIL PROTECTED]> added the comment: RFC2617 says that the authentication scheme should be case insensitive. Included is a patch which changes the string to uppercase before comparison. -- keywords: +patch nosy: +BitTorment Added file: http://bugs.python.org/file10189/

[issue2695] Ignore case when checking algorithm in urllib2

david reid <[EMAIL PROTECTED]> added the comment: The patch is inline. There's not much to it :-) Agree with your suggestion to avoid calling lower() twice. __ Tracker <[EMAIL PROTECTED]> __ _

[issue2695] Ignore case when checking algorithm in urllib2

Terry J. Reedy <[EMAIL PROTECTED]> added the comment: Function is about 2/3rds down in urllib2. Note 1: hashlib checks upper and lower case versions of names. So this seems like reasonable request. Note 2: I would start hashlib.__get_builtin_constructor(name): with 'name = name.lower()' and rep

[issue2695] Ignore case when checking algorithm in urllib2

Changes by Terry J. Reedy <[EMAIL PROTECTED]>: __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/m

[issue2695] Ignore case when checking algorithm in urllib2

Changes by Terry J. Reedy <[EMAIL PROTECTED]>: __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/m

[issue2695] Ignore case when checking algorithm in urllib2

Terry J. Reedy <[EMAIL PROTECTED]> added the comment: Whoops, just checked the title. Function is about 2/3rds down in urllib2. comments still apply Note 4: I consider 'name = lambda ...' inferior to 'def name...' but I am not the one who will edit this. __ Trac

[issue2695] Ignore case when checking algorithm in urllib2

Terry J. Reedy <[EMAIL PROTECTED]> added the comment: What module is this in that you want to change? Note 1: hashlib checks upper and lower case versions of names. So this seems like reasonable request. Note 2: I would start hashlib.__get_builtin_constructor(name): with 'name = name.lower()' a

[issue2695] Ignore case when checking algorithm in urllib2

New submission from david reid <[EMAIL PROTECTED]>: Small change to allow get_algorithm_impls to correctly detect when lower case algorithm strings are passed. I recently ran into a server that sent 'md5' and so this function failed without this small change. def get_algorithm_impls(self, al