[issue26868] Document PyModule_AddObject's behavior on error

miss-islington added the comment: New changeset c8d1338441114fbc504625bc66607e7996018a5d by Miss Islington (bot) in branch '3.7': bpo-26868: Fix example usage of PyModule_AddObject. (GH-15725) https://github.com/python/cpython/commit/c8d1338441114fbc504625bc66607e7996018a5d --

[issue26868] Document PyModule_AddObject's behavior on error

miss-islington added the comment: New changeset 535863e3f599a6ad829204d83f144c91e44de443 by Miss Islington (bot) in branch '3.8': bpo-26868: Fix example usage of PyModule_AddObject. (GH-15725) https://github.com/python/cpython/commit/535863e3f599a6ad829204d83f144c91e44de443 -- nosy:

[issue26868] Document PyModule_AddObject's behavior on error

Stéphane Wirtel added the comment: New changeset 224b8aaa7e8f67f748e8b7b6a4a77a25f6554651 by Stéphane Wirtel (Brandt Bucher) in branch 'master': bpo-26868: Fix example usage of PyModule_AddObject. (#15725) https://github.com/python/cpython/commit/224b8aaa7e8f67f748e8b7b6a4a77a25f6554651

[issue26868] Document PyModule_AddObject's behavior on error

Change by miss-islington : -- pull_requests: +15659 pull_request: https://github.com/python/cpython/pull/16037 ___ Python tracker ___ __

[issue26868] Document PyModule_AddObject's behavior on error

Change by miss-islington : -- pull_requests: +15660 pull_request: https://github.com/python/cpython/pull/16038 ___ Python tracker ___ __

[issue26868] Document PyModule_AddObject's behavior on error

Change by Ma Lin : -- nosy: +Ma Lin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/m

[issue26868] Document PyModule_AddObject's behavior on error

Change by Brandt Bucher : -- pull_requests: +15380 pull_request: https://github.com/python/cpython/pull/15725 ___ Python tracker ___ ___

[issue26868] Document PyModule_AddObject's behavior on error

Brandt Bucher added the comment: It looks like the idiom of calling PyModule_AddObject without Py_DECREF'ing on the error condition (or even checking for it at all) has spread quite a bit since this first reported. I'm preparing a PR to fix the other call sites. -- nosy: +brandtbuche

[issue26868] Document PyModule_AddObject's behavior on error

Change by Nir Soffer : -- nosy: +nirs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue26868] Document PyModule_AddObject's behavior on error

Change by Serhiy Storchaka : -- versions: +Python 3.8 -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue26868] Document PyModule_AddObject's behavior on error

Serhiy Storchaka added the comment: issue26868_v2.diff LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue26868] Document PyModule_AddObject's behavior on error

Berker Peksag added the comment: Serhiy, do you have further comments about issue26868_v2.diff? -- versions: +Python 3.7 ___ Python tracker ___ __

[issue26868] Document PyModule_AddObject's behavior on error

Berker Peksag added the comment: Thanks for the review Serhiy. Here is an updated patch. -- Added file: http://bugs.python.org/file43328/issue26868_v2.diff ___ Python tracker ___

[issue26868] Document PyModule_AddObject's behavior on error

Changes by Berker Peksag : -- title: Incorrect check for return value of PyModule_AddObject in _csv.c -> Document PyModule_AddObject's behavior on error ___ Python tracker ___ _