[issue26643] regrtest: rework libregrtest.save_env submodule

STINNER Victor added the comment: regrtest now always displays before/after when the environment is altered. I consider that it's enough to close this issue. I'm no more interested to try to enhance the output. -- resolution: -> fixed stage: -> resolved status: open -> closed __

[issue26643] regrtest: rework libregrtest.save_env submodule

Roundup Robot added the comment: New changeset c5944a76697b by Victor Stinner in branch '3.5': Issue #26643: Add missing shutil resources to regrtest.py https://hg.python.org/cpython/rev/c5944a76697b -- nosy: +python-dev ___ Python tracker

[issue26643] regrtest: rework libregrtest.save_env submodule

Serhiy Storchaka added the comment: > I replaced get_sys_path()/restore_sys_path() (2 methods) with > ModuleAttr.get()+ModuleAttrList.encode_value() / > ModuleAttr.restore()+ModuleAttrList.restore_attr() (4 methods). I need to examine all other methods scattered around just to conclude that th

[issue26643] regrtest: rework libregrtest.save_env submodule

STINNER Victor added the comment: > Consider your example with the 'sys.path' resource. With current code I need > to understand only 3 simple lines of the code in two close methods. With the > patch I need to research 4 classes with 16 complicated methods! This is awful! I replaced get_sys_pa

[issue26643] regrtest: rework libregrtest.save_env submodule

Serhiy Storchaka added the comment: Old code looks much clearer to me. Consider your example with the 'sys.path' resource. With current code I need to understand only 3 simple lines of the code in two close methods. With the patch I need to research 4 classes with 16 complicated methods! This

[issue26643] regrtest: rework libregrtest.save_env submodule

New submission from STINNER Victor: (I pushed the change 245a16f33c4b, but Serhiy asked me to review it and discuss it. So I reverted my change and created this issue.) I noticed many times that buildbots log "test xxx changed yyy" but this line is not enough to debug the issue. I propose to a