[issue26639] Tools/i18n/pygettext.py: replace deprecated imp module with importlib

Changes by Zachary Ware : -- hgrepos: -340 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue26639] Tools/i18n/pygettext.py: replace deprecated imp module with importlib

STINNER Victor added the comment: > pygettext_imp.patch looks good to me. Thanks for the review. > I left a comment on Rietveld. Oops, I added it but then inlined the function in caller sites. I removed the now empty function :-) -- resolution: -> fixed status: open -> closed _

[issue26639] Tools/i18n/pygettext.py: replace deprecated imp module with importlib

Roundup Robot added the comment: New changeset cd03ff74eaea by Victor Stinner in branch 'default': Update pygettext.py to get ride of imp https://hg.python.org/cpython/rev/cd03ff74eaea -- nosy: +python-dev ___ Python tracker

[issue26639] Tools/i18n/pygettext.py: replace deprecated imp module with importlib

Berker Peksag added the comment: pygettext_imp.patch looks good to me. I left a comment on Rietveld. -- ___ Python tracker ___ ___ Pyt

[issue26639] Tools/i18n/pygettext.py: replace deprecated imp module with importlib

Changes by Berker Peksag : -- components: -Benchmarks, Unicode stage: -> patch review type: compile error -> enhancement versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5 ___ Python tracker _

[issue26639] Tools/i18n/pygettext.py: replace deprecated imp module with importlib

Changes by supriyanto maftuh,st : -- components: +Benchmarks, Demos and Tools, Unicode hgrepos: +340 nosy: +ezio.melotti, pitrou, supriyanto maftuh type: -> compile error versions: +Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5 ___ Pytho

[issue26639] Tools/i18n/pygettext.py: replace deprecated imp module with importlib

STINNER Victor added the comment: Can someone please review pygettext_imp.patch? (I send a ping since Roundup email notifications were broken recently.) -- ___ Python tracker __

[issue26639] Tools/i18n/pygettext.py: replace deprecated imp module with importlib

STINNER Victor added the comment: See also the issue #20021 '"modernize" makeopcodetargets.py"' (now closed). -- nosy: +berker.peksag, serhiy.storchaka ___ Python tracker ___ ___

[issue26639] Tools/i18n/pygettext.py: replace deprecated imp module with importlib

New submission from STINNER Victor: Attached patch replaces the imp module with importlib in Tools/i18n/pygettext.py. Please review carefully, it looks like the code getting the filename of a Python module is not tested by Lib/test/test_tools.py :-/ -- files: pygettext_imp.patch keywo