[issue26457] Error in ipaddress.address_exclude function

2016-03-01 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue26457] Error in ipaddress.address_exclude function

2016-03-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6d6c0a7b71f5 by Serhiy Storchaka in branch '3.5': Issue #26457: Fixed the subnets() methods in IP network classes for the case https://hg.python.org/cpython/rev/6d6c0a7b71f5 New changeset c092148a1b55 by Serhiy Storchaka in branch 'default': Issue #

[issue26457] Error in ipaddress.address_exclude function

2016-03-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. I have wrote similar patch but with different tests. -- assignee: -> serhiy.storchaka stage: needs patch -> commit review versions: +Python 3.6 ___ Python tracker

[issue26457] Error in ipaddress.address_exclude function

2016-02-29 Thread Xiang Zhang
Xiang Zhang added the comment: I propose a patch simply add one to end so that the broadcast address network will appear in the result, which behaves the same as ipaddr.py. Corresponding tests are added. All tests are passed but I am afraid some logic may break. -- keywords: +patch Add

[issue26457] Error in ipaddress.address_exclude function

2016-02-29 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue26457] Error in ipaddress.address_exclude function

2016-02-29 Thread Xiang Zhang
Xiang Zhang added the comment: In old ipaddr.py, IPv4Network('192.0.2.0/31').subnet() returns [IPv4Network('192.0.2.0/32'), IPv4Network('192.0.2.1/32')], but ipaddress returns only [IPv4Network('192.0.2.0/32')]. It seems simply change end to end+1 in https://hg.python.org/cpython/file/tip/Li

[issue26457] Error in ipaddress.address_exclude function

2016-02-28 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +ncoghlan, pmoody ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue26457] Error in ipaddress.address_exclude function

2016-02-28 Thread Xiang Zhang
Changes by Xiang Zhang <18518281...@126.com>: -- nosy: +xiang.zhang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue26457] Error in ipaddress.address_exclude function

2016-02-28 Thread feng liang
New submission from feng liang: when i read in document 3.5.1,run the example in ipaddress.address_exclude function >>> n1 = ip_network('192.0.2.0/28') >>> n2 = ip_network('192.0.2.1/32') >>> list(n1.address_exclude(n2)) I got: Traceback (most recent call last): File "", line 1, in Fi