[issue26173] test_ssl.bad_cert_test() exception handling

Changes by Martin Panter : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue26173] test_ssl.bad_cert_test() exception handling

Roundup Robot added the comment: New changeset 6f7b2b7a029a by Martin Panter in branch '2.7': Issue #26173: Separate bad cert file tests and client rejection test https://hg.python.org/cpython/rev/6f7b2b7a029a -- ___ Python tracker

[issue26173] test_ssl.bad_cert_test() exception handling

Roundup Robot added the comment: New changeset 6d068205b580 by Martin Panter in branch '3.5': Issue #26173: Separate bad cert file tests and client rejection test https://hg.python.org/cpython/rev/6d068205b580 New changeset 3b211ee66b82 by Martin Panter in branch 'default': Issue #26173: Merge S

[issue26173] test_ssl.bad_cert_test() exception handling

Berker Peksag added the comment: Looks good to me. Thanks Martin. -- nosy: +berker.peksag stage: patch review -> commit review ___ Python tracker ___

[issue26173] test_ssl.bad_cert_test() exception handling

Martin Panter added the comment: Updated patch; thanks for the comments Berker -- Added file: http://bugs.python.org/file41763/separate-test-py3.v2.patch ___ Python tracker ___ _

[issue26173] test_ssl.bad_cert_test() exception handling

Martin Panter added the comment: I was mistaken about what test_wrong_cert() is doing. It tells the _server_ to check the _client’s_ certificate (the opposite way around from HTTPS for example). Now I understand this, I see it is fine for the client to raise ECONNRESET if the server rejected i

[issue26173] test_ssl.bad_cert_test() exception handling

Roundup Robot added the comment: New changeset c75ae81b5058 by Martin Panter in branch '3.5': Issue #26173: Fix test_ssl confusion with non-existing cert and wrongcert.pem https://hg.python.org/cpython/rev/c75ae81b5058 New changeset 284b3de802b7 by Martin Panter in branch 'default': Issue #26173

[issue26173] test_ssl.bad_cert_test() exception handling

Roundup Robot added the comment: New changeset 14463726a4a0 by Martin Panter in branch '2.7': Issue #26173: Fix test_ssl confusion with non-existing cert and wrongcert.pem https://hg.python.org/cpython/rev/14463726a4a0 -- nosy: +python-dev ___ Python

[issue26173] test_ssl.bad_cert_test() exception handling

Martin Panter added the comment: wrong-cert-py3.patch is similar but also adds the wrongcert.pem file from Python 2. -- keywords: -buildbot stage: needs patch -> patch review Added file: http://bugs.python.org/file41736/wrong-cert-py3.patch ___ Pyth

[issue26173] test_ssl.bad_cert_test() exception handling

Martin Panter added the comment: There are more mistakes in the history of test_nonexisting_cert(). In revision 8a281bfc058d (Python 2.6), the method was added as testWrongCert(), with an existing but non-matching certificate file. But when this was ported to Python 3 in r66311, the wrongcert.

[issue26173] test_ssl.bad_cert_test() exception handling

Changes by Martin Panter : -- keywords: +patch Added file: http://bugs.python.org/file41725/bad-cert-py3.patch ___ Python tracker ___

[issue26173] test_ssl.bad_cert_test() exception handling

New submission from Martin Panter: In bad_cert_test(), there are two OSError exception handler; one masking the other. In Python 3, I think we should remove the second (dead) handler. In Python 2, maybe the first OSError handler should catch socket.error instead. Originally, in r80534, socket.