[issue26121] Use C99 functions in math if available

Changes by Paul Romano : -- pull_requests: +3594 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue26121] Use C99 functions in math if available

Mark Dickinson added the comment: New changeset 97553fdf9daa8231eb05a1ca9933a2b03b0bdad0 by Mark Dickinson (Serhiy Storchaka) in branch 'master': bpo-26121: Use C library implementation for math functions: (#515) https://github.com/python/cpython/commit/97553fdf9daa8231eb05a1ca9933a2b03b0bdad0

[issue26121] Use C99 functions in math if available

Serhiy Storchaka added the comment: New changeset 4125e5c60e24ffcff8031817dc60984335917f59 by Serhiy Storchaka in branch 'master': bpo-26121: Revert to using the own implementations of lgamma and gamma on all platforms. (#637) https://github.com/python/cpython/commit/4125e5c60e24ffcff8031817dc

[issue26121] Use C99 functions in math if available

Serhiy Storchaka added the comment: New changeset 4dadcd4ed7824c7904add78577e6a05864cfe493 by Serhiy Storchaka in branch 'master': bpo-26121: Use C library implementation for math functions erf() and erfc() on Windows. (#632) https://github.com/python/cpython/commit/4dadcd4ed7824c7904add78577e

[issue26121] Use C99 functions in math if available

Changes by Larry Hastings : -- pull_requests: +622 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue26121] Use C99 functions in math if available

Changes by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue26121] Use C99 functions in math if available

Serhiy Storchaka added the comment: Done. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue26121] Use C99 functions in math if available

Serhiy Storchaka added the comment: PR 637 revert to using the own implementations of lgamma and gamma on all platforms. -- ___ Python tracker ___ __

[issue26121] Use C99 functions in math if available

Changes by Serhiy Storchaka : -- pull_requests: +526 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue26121] Use C99 functions in math if available

Mark Dickinson added the comment: Please can we revert to using the existing implementations of lgamma and gamma on all platforms? It's clear that there are many issues with OS-provided implementations. -- ___ Python tracker

[issue26121] Use C99 functions in math if available

Serhiy Storchaka added the comment: There are accuracy issues with tgamma() and lgamma() on Windows. But less than on OS X. == FAIL: test_mtestfile (test.test_math.MathTests)

[issue26121] Use C99 functions in math if available

Serhiy Storchaka added the comment: PR 632 switch on using libc implementation on Windows. Will see how AppVeyor tests passed. -- ___ Python tracker ___

[issue26121] Use C99 functions in math if available

Changes by Serhiy Storchaka : -- pull_requests: +520 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue26121] Use C99 functions in math if available

Serhiy Storchaka added the comment: Tests are failed only on s390x RHEL 3.x. http://buildbot.python.org/all/builders/s390x%20RHEL%203.x/builds/446/steps/test/logs/stdio == FAIL: test_mtestfile (test.test_math.MathTests)

[issue26121] Use C99 functions in math if available

Mark Dickinson added the comment: So the GitHub branch fails on my OS X 10.10 machine: there are a number of test failures for gamma and lgamma (but none for erf and erfc). Some of the gamma and lgamma test failures are accuracy issues; some are more likely to do with errno handling: OS X prob

[issue26121] Use C99 functions in math if available

Serhiy Storchaka added the comment: I don't know how to run custom build on buildbots with new workflow. -- versions: +Python 3.7 -Python 3.6 ___ Python tracker ___ _

[issue26121] Use C99 functions in math if available

Changes by Serhiy Storchaka : -- pull_requests: +424 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue26121] Use C99 functions in math if available

Serhiy Storchaka added the comment: The benchmarks were ran on 32-bit Linux with AMD processor. I'll try to run custom build on buildbots. -- ___ Python tracker ___

[issue26121] Use C99 functions in math if available

Mark Dickinson added the comment: LGTM. What platform are the benchmarks on? Is there some way that this can be submitted to the buildbots *before* applying to the 3.6 branch, so that we can get a sense of how widespread (if at all) libm problems are? -- _

[issue26121] Use C99 functions in math if available

Changes by Yury Selivanov : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue26121] Use C99 functions in math if available

Christian Heimes added the comment: Faster: maybe. More accurate ... Mark can tell you some funny stories. :) -- nosy: +christian.heimes ___ Python tracker ___ __

[issue26121] Use C99 functions in math if available

New submission from Serhiy Storchaka: Currently the math module uses own implementation of some mathematical functions that are in C99 standard, but not in C89 standard: tgamma, lgamma, erf, erfc. Proposed patch makes it to use functions from standard C library if they are available. They are