[issue25770] expose name, args, and kwargs from methodcaller

Guido van Rossum added the comment: To me, the best rhythm has always been (*args, **kwds). -- ___ Python tracker ___ ___ Python-bugs-

[issue25770] expose name, args, and kwargs from methodcaller

Joe Jevnik added the comment: people have had some time to think about this, whats should the name be so we can merge this? -- ___ Python tracker ___ ___

[issue25770] expose name, args, and kwargs from methodcaller

Serhiy Storchaka added the comment: functools.partial is not the only precedence. The "kwargs" attribute is used in following classes: concurrent.futures.process._CallItem concurrent.futures.process._WorkItem concurrent.futures.thread._WorkItem inspect.BoundArguments sched.Event threading.Timer

[issue25770] expose name, args, and kwargs from methodcaller

Raymond Hettinger added the comment: Now that partial() has started down the path of using "keywords", it seems reasonable to stick with that name. In pure python code, we mostly use **kwds or **kwargs but there are other variants and not much consistency, so spelling out keywords isn't unrea

[issue25770] expose name, args, and kwargs from methodcaller

Serhiy Storchaka added the comment: I don't like the name "keywords". May be I'm not right. Needed opinions of other core developers. -- ___ Python tracker ___ _

[issue25770] expose name, args, and kwargs from methodcaller

Joe Jevnik added the comment: ping: any decision on this? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue25770] expose name, args, and kwargs from methodcaller

Joe Jevnik added the comment: Is there a decision on the name? I can update the patch if needed. -- ___ Python tracker ___ ___ Python-

[issue25770] expose name, args, and kwargs from methodcaller

Joe Jevnik added the comment: partial's unique usage is why I feel like it would be so jarring for them do be named differently. I would be happiest having this feature at all so I will change the name to 'kwargs' if you would like. I just want to be sure that my reasons for choosing this name

[issue25770] expose name, args, and kwargs from methodcaller

Serhiy Storchaka added the comment: functools.partial() is unique in it's usage of name "keywords". -- nosy: +ncoghlan, rhettinger ___ Python tracker ___

[issue25770] expose name, args, and kwargs from methodcaller

Joe Jevnik added the comment: I agree that it is a strange name and I also think that it could be immutable or a copy of the internal dict; however, I think that consistency with existing APIs in the standard library is more important. 'keywords' is still very clear in context and is used in '

[issue25770] expose name, args, and kwargs from methodcaller

Serhiy Storchaka added the comment: "keywords" is unusual name. The most used name for the dict of keyword arguments is "kwargs". $ find Lib/ -name '*.py' -exec egrep -ho '\*\*[a-zA-Z_0-9]+' '{}' + | sort | uniq -c | sort -nr | head 803 **kwargs 442 **kw 244 **kwds ... If you want

[issue25770] expose name, args, and kwargs from methodcaller

Joe Jevnik added the comment: I only want this feature to keep the usage close to functools.partial. I was actually sort of surprised to see that mutation of the dict held in partial, but I would rather be consistent. -- ___ Python tracker

[issue25770] expose name, args, and kwargs from methodcaller

Martin Panter added the comment: This is a bit odd. You can mutate the keyword arguments, but you are not allowed to change the positional arguments (“args” is readonly). If you want this to be part of the supported API, it should be documented, but it seems like bad design IMO. -- _

[issue25770] expose name, args, and kwargs from methodcaller

Joe Jevnik added the comment: Added a test case for the mutation of keywords. -- Added file: http://bugs.python.org/file41204/methodcaller-attrs-2.patch ___ Python tracker ___ __

[issue25770] expose name, args, and kwargs from methodcaller

Joe Jevnik added the comment: Thanks for pointing me at the refleak, uploading an update -- Added file: http://bugs.python.org/file41203/methodcaller-attrs-1.patch ___ Python tracker ___

[issue25770] expose name, args, and kwargs from methodcaller

Martin Panter added the comment: Left a review comment which may help you chase that refleak Also, as a new feature, surely it should be documented? -- nosy: +martin.panter ___ Python tracker _

[issue25770] expose name, args, and kwargs from methodcaller

Joe Jevnik added the comment: Thanks for review, looking into the reference count issue. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue25770] expose name, args, and kwargs from methodcaller

Stéphane Wirtel added the comment: Hi, I just tried your patch with the last revision and I have an error with the tests. stephane@sg1 ~/s/h/cpython> ./python -m test test_operator [1/1] test_operator Fatal Python error: ./Modules/_operator.c:975 object at 0x7ff804c2e3d8 has negative ref coun

[issue25770] expose name, args, and kwargs from methodcaller

Changes by Emanuel Barry : -- nosy: +ebarry stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue25770] expose name, args, and kwargs from methodcaller

New submission from Joe Jevnik: This patch adds 3 properties to methodcaller objects for inspecting the object at runtime: 1. 'name': the name of the method to call 2. 'args': the position arguments to pass to the method 3. 'keywords': the keyword arguments to pass to the method args and keywo