[issue25665] typing.NamedTuple instances are not picklable.

2015-11-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4f30b0d47c24 by Serhiy Storchaka in branch '3.5': Issue #25665: Test pickling with all protocols in test_typing. https://hg.python.org/cpython/rev/4f30b0d47c24 New changeset 9e65015582a5 by Serhiy Storchaka in branch 'default': Issue #25665: Test pi

[issue25665] typing.NamedTuple instances are not picklable.

2015-11-20 Thread Guido van Rossum
Guido van Rossum added the comment: Serhiy, feel free to commit that patch. I was just being lazy. Also, I was using assert instead of self.assertEquals etc. out of laziness (and because at Dropbox people have got the py.test religion and prefer to use assert statements -- but I'm not keen to

[issue25665] typing.NamedTuple instances are not picklable.

2015-11-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The test tests pickling only with default protocol. It would be better to test pickling with all supported protocols. Why special TestCase methods to check for and report failures are not used in test_typing? -- nosy: +serhiy.storchaka Added file: h

[issue25665] typing.NamedTuple instances are not picklable.

2015-11-19 Thread Guido van Rossum
Guido van Rossum added the comment: Fixed it! Thanks for the report *and* the patch. I wrote a different test though. -- assignee: -> gvanrossum resolution: -> fixed status: open -> closed versions: +Python 3.6 ___ Python tracker

[issue25665] typing.NamedTuple instances are not picklable.

2015-11-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 33df0056c148 by Guido van Rossum in branch '3.5': Issue #25665: Make NamedTuple picklable. https://hg.python.org/cpython/rev/33df0056c148 New changeset 8a32d44b8359 by Guido van Rossum in branch 'default': Issue #25665: Make NamedTuple picklable. (M

[issue25665] typing.NamedTuple instances are not picklable.

2015-11-19 Thread Ashwini Chaudhary
Ashwini Chaudhary added the comment: Attached patch. -- keywords: +patch Added file: http://bugs.python.org/file41073/issue25665.patch ___ Python tracker ___

[issue25665] typing.NamedTuple instances are not picklable.

2015-11-19 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +gvanrossum, rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25665] typing.NamedTuple instances are not picklable.

2015-11-19 Thread Ashwini Chaudhary
New submission from Ashwini Chaudhary: Currently namedtuple(https://hg.python.org/cpython/file/3.5/Lib/collections/__init__.py#l418) sets the `__module__` attribute by looking up `__name__` in calling frame's globals. As in the case of `typing.NamedTuple` it is always going to be 'typing' pic