[issue25595] test_deleted_cwd in test_importlib is failed on AIX

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

Roundup Robot added the comment: New changeset d4dc36586f24 by Serhiy Storchaka in branch '3.5': Issue #25595: Fixed test_deleted_cwd in test_importlib on AIX. https://hg.python.org/cpython/rev/d4dc36586f24 New changeset 3f392050d519 by Serhiy Storchaka in branch 'default': Issue #25595: Fixed t

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

Serhiy Storchaka added the comment: Martin's original code looked nicer to me. It' a pity we can't use it. test_deleted_cwd_aix_3.patch LGTM. Thanks Martin! -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

Martin Panter added the comment: Wow this is tricky to get right. Victor, you are right to not trust TemporaryDirectory, because when cleanup() fails you don’t get a second chance, and it will leave the directory behind. According to the Microsoft _mkdir() web page

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

STINNER Victor added the comment: test_deleted_cwd_aix_alt.patch: I don't trust tempfile.TemporaryDirectory(), I prefer your patch. test_deleted_cwd_aix_2.patch looks good to me. -- ___ Python tracker ___

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

Serhiy Storchaka added the comment: And here is simple alternative patch based on Martin's original suggestion in msg236122. -- Added file: http://bugs.python.org/file40998/test_deleted_cwd_aix_alt.patch ___ Python tracker

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

Serhiy Storchaka added the comment: Thank you Victor for your review. Here is fixed patch that implements your suggestions. -- Added file: http://bugs.python.org/file40997/test_deleted_cwd_aix_2.patch ___ Python tracker

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

STINNER Victor added the comment: -1, review on Rietveld. -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

New submission from Serhiy Storchaka: test_deleted_cwd in test_importlib is failed on AIX. http://buildbot.python.org/all/builders/PPC64%20AIX%203.x/builds/4318/steps/test/logs/stdio == ERROR: test_deleted_cwd (test.test_import