[issue25449] Test OrderedDict subclass

2015-11-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: 59c7615ea921 and 76e848554b5d were related to issue24726. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue25449] Test OrderedDict subclass

2015-11-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 499398d91b97 by Serhiy Storchaka in branch '3.5': Issue #25449: Iterating OrderedDict with keys with unstable hash now raises https://hg.python.org/cpython/rev/499398d91b97 New changeset 9db4191723eb by Serhiy Storchaka in branch 'default': Issue #2

[issue25449] Test OrderedDict subclass

2015-10-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New patch adds PurePythonOrderedDictSubclassTests, moves all tests except test_key_change_during_iteration from CPythonOrderedDictTests to OrderedDictTests to test Python implementation too, fixes a bug in values and items iteration that caused test_issue243

[issue25449] Test OrderedDict subclass

2015-10-21 Thread Eric Snow
Changes by Eric Snow : -- stage: commit review -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25449] Test OrderedDict subclass

2015-10-21 Thread Eric Snow
Eric Snow added the comment: Regarding dict.__setitem__, see issue #24726. Raymond outlined what needs to be fixed. -- ___ Python tracker ___ __

[issue25449] Test OrderedDict subclass

2015-10-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The patch was not ready for commit. The problem is that test_issue24347 fails in CPythonOrderedDictSubclassTests. The failure is random, you need to run test several times to encounter it. Experimenting with this test I found other bug probably related to is

[issue25449] Test OrderedDict subclass

2015-10-20 Thread Eric Snow
Eric Snow added the comment: LGTM as long as you also add PurePythonOrderedDictSubclassTests to match CPythonOrderedDictSubclassTests (per PEP 399). -- nosy: +eric.snow stage: -> commit review ___ Python tracker

[issue25449] Test OrderedDict subclass

2015-10-20 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: C implementation of OrderedDict often has two paths. One for exact OrderedDict and other for subclasses. But only one of the paths is tested. Proposed patch adds tests for a subclass of C implemented OrderedDict. test_issue24347 is failed with OrderedDict s