R. David Murray added the comment:
Thanks, Xiang. Your analysis was correct and your patch is good.
For anyone who is curious, Barry discovered this while writing tests for a new
aiosmtpd, which is based on the existing smtpd code.
--
resolution: -> fixed
stage: -> resolved
status:
Roundup Robot added the comment:
New changeset d471cf4a73b2 by R David Murray in branch '3.5':
#25328: add missing raise keyword in decode_data+SMTPUTF8 check.
https://hg.python.org/cpython/rev/d471cf4a73b2
New changeset 576128c0d068 by R David Murray in branch 'default':
Merge #25328: add missi
Xiang Zhang added the comment:
I think this is a typo. The raise is left out.
In test_smtpd.py, it only tests the raise condition in SMTPServer but
not STMPChannel.
I add the raise and a corresponding test in SMTPDChannelTest.
--
keywords: +patch
nosy: +xiang.zhang
Added file: http://b
Barry A. Warsaw added the comment:
On Oct 08, 2015, at 08:44 PM, Mauro S. M. Rodrigues wrote:
>Python 3.5.0+ (3.5:1e99ba6b7c98, Oct 8 2015, 17:12:06)
>[GCC 4.8.4] on linux
>Type "help", "copyright", "credits" or "license" for more information.
import smtpd
smtpd.SMTPServer(("127.0.0.
Mauro S. M. Rodrigues added the comment:
Hi Barry, I was testing this and it seems to work, am I doing something wrong
in order to reproduce it? I've used the same parameters from the unit tests
Python 3.5.0+ (3.5:1e99ba6b7c98, Oct 8 2015, 17:12:06)
[GCC 4.8.4] on linux
Type "help", "copyrigh
New submission from Barry A. Warsaw:
In Python 3.5, SMTPChannel.__init__() ensures that enable_SMTPUTF8 and
decode_data arguments are not both true. This even seems to be tested in
test_smtpd.py. But it's clearly bogus because the exception is never raised!
It just creates and throws away t
