[issue2521] ABC caches should use weak refs

Amaury Forgeot d'Arc added the comment: bluag: the script you run contains a list of some modules required to start Python (I found a copy here: https://github.com/pinax/pinax/raw/master/scripts/pinax-boot.py ) This script is obviously out of date wrt the new version of Python. Please report

[issue2521] ABC caches should use weak refs

H. added the comment: ImportError: No module named _weakrefset Here are some references while i was trying to install Pinax framework. http://paste.pound-python.org/show/6536/ And i saw that the _weakrefset.py is not included in the package. So I have copied from Python's source with version

[issue2521] ABC caches should use weak refs

Daniel Stutzbach added the comment: Thanks! :-) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue2521] ABC caches should use weak refs

Benjamin Peterson added the comment: r84230 -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-lis

[issue2521] ABC caches should use weak refs

Daniel Stutzbach added the comment: Attached is a new test case, based on Benjamin's comments. -- Added file: http://bugs.python.org/file18567/leak_test2.patch ___ Python tracker ___

[issue2521] ABC caches should use weak refs

Changes by Daniel Stutzbach : -- components: +Library (Lib) -Interpreter Core versions: -Python 2.6 ___ Python tracker ___ ___ Python-

[issue2521] ABC caches should use weak refs

Daniel Stutzbach added the comment: Benjamin, Thanks for the feedback. Since you only commented on the test case, may I assume that the fix itself looked good to you? I will work on revising the test case based on your comments. Since I ran into the bug while working with the ABCs in the c

[issue2521] ABC caches should use weak refs

Benjamin Peterson added the comment: Some comments: - The test should be in test_abc.py and should probably not use a collections class. - Use test_support.gc_collect(). - What's the __len__() stuff for? -- keywords: -26backport ___ Python tracker

[issue2521] ABC caches should use weak refs

Daniel Stutzbach added the comment: Jack, The change is necessary because "None in WeakSet()" would throw an exception. -- ___ Python tracker ___ ___

[issue2521] ABC caches should use weak refs

Jack Diederich added the comment: This is a change in the codepath for instances that don't have __class__ defined. subclass = getattr(instance, '__class__', None) -if subclass in cls._abc_cache: +if subclass is not None and subclass in cls._abc_cache: I think the same

[issue2521] ABC caches should use weak refs

Mark Lawrence added the comment: Can a committer take a look at this please. -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue2521] ABC caches should use weak refs

Mark Lawrence added the comment: Patched the unit test, then ran the test before applying the fix which failed, after applying the fix the test ran successfully. Tested on Windows Vista 32 bit against 2.7 maintainance release. The patches are short and sweet, I see no reason why they can't

[issue2521] ABC caches should use weak refs

Antoine Pitrou added the comment: > Antoine, do you have a suggestion for someone with with better > knowledge of ABCs to do the final review, so that I may very politely > pester them? ;-) I guess Benjamin could. -- ___ Python tracker

[issue2521] ABC caches should use weak refs

Daniel Stutzbach added the comment: Antoine, do you have a suggestion for someone with with better knowledge of ABCs to do the final review, so that I may very politely pester them? ;-) -- ___ Python tracker _

[issue2521] ABC caches should use weak refs

Changes by Michael Foord : -- stage: unit test needed -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue2521] ABC caches should use weak refs

Daniel Stutzbach added the comment: Someone with appropriate permissions want to update the "Stage"? -- versions: +Python 2.7 ___ Python tracker ___ _

[issue2521] ABC caches should use weak refs

Antoine Pitrou added the comment: Someone with a better knowledge of ABCs than me should probably do a final review of this. -- ___ Python tracker ___ __

[issue2521] ABC caches should use weak refs

Changes by Daniel Stutzbach : Removed file: http://bugs.python.org/file16690/abc_leak.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue2521] ABC caches should use weak refs

Daniel Stutzbach added the comment: New patches uploaded. I separated out the patch to add the test case, to make it easier to test before and after applying the fix. -- Added file: http://bugs.python.org/file16714/leak_test.patch ___ Python tracke

[issue2521] ABC caches should use weak refs

Changes by Daniel Stutzbach : Added file: http://bugs.python.org/file16713/abc_leak.patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue2521] ABC caches should use weak refs

Daniel Stutzbach added the comment: Cool! I will revise the patch based on your comments about my test case. -- ___ Python tracker ___ __

[issue2521] ABC caches should use weak refs

Antoine Pitrou added the comment: > Make old-style classes weak-referenceable Now done (r79535). -- ___ Python tracker ___ ___ Python

[issue2521] ABC caches should use weak refs

Daniel Stutzbach added the comment: You can't register an old-style class, but many ABCs support duck-typing by implementing __subclasshook__. ABCMeta caches those results and stores a reference to old-style classes, sometimes in _abc_cache and sometimes in _abc_negative_cache. It can't sim

[issue2521] ABC caches should use weak refs

Florent Xicluna added the comment: > ABCTestCase.validate_isinstance ... specifically tests that > both new-style and old-style classes work... I fixed some parts with issue #7624, and changeset r78800. -- ___ Python tracker

[issue2521] ABC caches should use weak refs

Benjamin Peterson added the comment: In those cases, it's because __subclasscheck__ is overridden. You can't register a old-style class. -- nosy: +benjamin.peterson ___ Python tracker _

[issue2521] ABC caches should use weak refs

Daniel Stutzbach added the comment: Are you sure the old-style classes don't support ABCs? ABCTestCase.validate_isinstance in Lib/test/test_collection.py specifically tests that both new-style and old-style classes work, unless I'm reading it wrong. (and those tests fail if I make ABCMeta.__

[issue2521] ABC caches should use weak refs

Daniel Stutzbach added the comment: I hadn't realized that old style classes didn't support ABCs. That certainly simplifies things! I'm working on a new patch. -- ___ Python tracker _

[issue2521] ABC caches should use weak refs

Antoine Pitrou added the comment: By the way, Daniel, your patch doesn't look right. First, you shouldn't need all the sortedlist/sortedset hierarchy. Second, len(gc.get_objects()) is a truly horrible way of checking the classes have been destroyed. Just take a weakref to the class before delet

[issue2521] ABC caches should use weak refs

Antoine Pitrou added the comment: Hmm, Benjamin pointed out that ABCs only support new-style classes, so old-style classes could be detected early instead of being added to the _abc_negative_cache. -- ___ Python tracker

[issue2521] ABC caches should use weak refs

Changes by Antoine Pitrou : -- dependencies: +Make old-style classes weak referenceable ___ Python tracker ___ ___ Python-bugs-list mai

[issue2521] ABC caches should use weak refs

Daniel Stutzbach added the comment: Now that WeakSet has been backported to trunk, I've backported the fix for this reference-leak (patch with test case attached). However, after making the patch, I discovered that old-style classes are not weak-referenceable. Consequently, the patch is not

[issue2521] ABC caches should use weak refs

Daniel Diniz added the comment: Confirmed on release26-maint and trunk. -- nosy: +ajaksu2 priority: -> normal stage: -> test needed type: -> resource usage ___ Python tracker

[issue2521] ABC caches should use weak refs

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- nosy: +pitrou __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe:

[issue2521] ABC caches should use weak refs

New submission from Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: The following function seems to 8 references each time it is run: import io, gc def f(): class C: pass c=C() assert isinstance(c, io.StringIO) is False gc.collect();gc.collect();gc.collect() This is because io.StringIO._