[issue25173] IDLE - several common dialogs don't have correct parent set

2015-09-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: Opened #25237 about Dialog+subclass docs. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue25173] IDLE - several common dialogs don't have correct parent set

2015-09-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset e406d62014f7 by Terry Jan Reedy in branch '2.7': Issue #25173: Replace 'master' with 'parent' in tkinter.messagebox calls. https://hg.python.org/cpython/rev/e406d62014f7 New changeset e494316a9291 by Terry Jan Reedy in branch '3.4': Issue #25173: Re

[issue25173] IDLE - several common dialogs don't have correct parent set

2015-09-19 Thread Mark Roseman
Mark Roseman added the comment: Attached masterparent27.patch, same thing for 2.7 branch -- Added file: http://bugs.python.org/file40518/masterparent27.patch ___ Python tracker _

[issue25173] IDLE - several common dialogs don't have correct parent set

2015-09-19 Thread Mark Roseman
Mark Roseman added the comment: I think both master and parent are needed, for the likely rare case when you don't want a dialog attached to any window, but it needs a Tk window handle to build the dialog from. Ran across that in SearchEngine, which has a root window just for the purpose of

[issue25173] IDLE - several common dialogs don't have correct parent set

2015-09-19 Thread Mark Roseman
Mark Roseman added the comment: No comment on state of Tkinter documentation. ;-) I'll have a go through the uses of 'master' in IDLE and see which others should be changed, and put together a patch. Plus double-check with all the other dialogs in lib/tkinter to see if there are any other gotc

[issue25173] IDLE - several common dialogs don't have correct parent set

2015-09-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: General comments on 'master' versus 'parent': This seems to be a matter of confusion in tkinterland. When I have asked before about the difference, all I have gotten is that they are more or less the same. http://effbot.org/tkinterbook/entry.htm, for instance,

[issue25173] IDLE - several common dialogs don't have correct parent set

2015-09-18 Thread Mark Roseman
New submission from Mark Roseman: The confirmation, file, etc. common dialogs in tkinter accept both a 'master' and a 'parent' argument. Master is not required (it will use parent if not provided). Parent is used to associate the dialog with a given window. On Mac OS X, using parent further tu