[issue25007] Add support of copy protocol to zlib compressors and decompressors

Serhiy Storchaka added the comment: Thank you for your contribution Zackery! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue25007] Add support of copy protocol to zlib compressors and decompressors

Serhiy Storchaka added the comment: New changeset d2cbfffc842b00b5257aa1c25dbcdeb456b6a249 by Serhiy Storchaka (Zackery Spytz) in branch 'master': bpo-25007: Add copy protocol support to zlib compressors and decompressors (GH-7940) https://github.com/python/cpython/commit/d2cbfffc842b00b5257

[issue25007] Add support of copy protocol to zlib compressors and decompressors

Change by Zackery Spytz : -- nosy: +ZackerySpytz versions: +Python 3.8 -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list maili

[issue25007] Add support of copy protocol to zlib compressors and decompressors

Change by Zackery Spytz : -- pull_requests: +7549 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mai

[issue25007] Add support of copy protocol to zlib compressors and decompressors

Changes by Serhiy Storchaka : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue25007] Add support of copy protocol to zlib compressors and decompressors

Serhiy Storchaka added the comment: I agree with Josh. Needed __deepcopy__ and tests. And I think there may be problem with sharing a docstring (that includes a signature) between copy() and __copy__(). It is better to just add separate method that calls the implementation of copy().

[issue25007] Add support of copy protocol to zlib compressors and decompressors

Josh Rosenberg added the comment: Patch looks good, but incomplete. Supporting __deepcopy__ (as a simple wrapper around __copy__ that ignores the second argument) would provide complete support. Also, should there be tests? I mean, I assume the .copy() method itself is tested, but just to det

[issue25007] Add support of copy protocol to zlib compressors and decompressors

shiyao.ma added the comment: per serhiy's suggestion, added two aliases. -- keywords: +patch nosy: +introom Added file: http://bugs.python.org/file40446/patch.diff ___ Python tracker ___

[issue25007] Add support of copy protocol to zlib compressors and decompressors

New submission from Serhiy Storchaka: zlib compressor and decompressor objects can be copied with the copy() method, but not with copy.copy(). It is easy to add support of copy protocol to them (just add __copy__() as an alias to copy()). -- components: Library (Lib) messages: 249902 n