[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

Terry J. Reedy added the comment: Upon writing a proof-of-concept file for #24981, I discovered an stdlib file that gave the same error. C:/programs/Python35/Lib\distutils/_msvccompiler.py ValueError: None disallowed in expression list I presume the applied fix will apply to this also. --

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

Yury Selivanov added the comment: Thanks Nick and Larry for code reviews and merge! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

Roundup Robot added the comment: New changeset e9df8543d7bc by Yury Selivanov in branch '3.5': Issue #24975: Fix AST compilation for PEP 448 syntax. https://hg.python.org/cpython/rev/e9df8543d7bc New changeset ea79be5b201e by Yury Selivanov in branch '3.5': Merge 3.5 heads (issue #24975) https:/

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

Larry Hastings added the comment: Merged. Please forward-merge to 3.5.1 and 3.6, thanks! -- ___ Python tracker ___ ___ Python-bugs-li

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

Brett Cannon added the comment: Created issue #24981 to track the test case idea. -- ___ Python tracker ___ ___ Python-bugs-list maili

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

Yury Selivanov added the comment: Larry, I created a PR for you: https://bitbucket.org/larry/cpython350/pull-requests/10/issue-24975-fix-ast-compilation-for-pep/diff Brett, Should we do that in a separate issue targeting 3.6 only? -- ___ Python tr

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

Brett Cannon added the comment: Do we not have a test that compiles the entire stdlib using the ast module? We used to have one for the old compiler package. If don't have such a test we should probably add it even if it requires a -u option. -- nosy: +brett.cannon ___

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

Nick Coghlan added the comment: Patch looks good to me. I was initially going to query the changes to the break/continue AST tests, but then realised they were needed to avoid a compile error for break/continue outside a loop now that we ensure the resulting AST can be used to generate code.

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

Larry Hastings added the comment: Good catch! Please file a pull request via bitbucket. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

Yury Selivanov added the comment: Good find, David. Thanks! Please review the attached patch. -- keywords: +patch nosy: +benjamin.peterson, larry, ncoghlan, serhiy.storchaka, yselivanov priority: normal -> release blocker stage: -> patch review versions: +Python 3.6 Added file: http://

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

New submission from David Beazley: The compile() function is not able to compile an AST created from code that uses some of the new unpacking generalizations in PEP 448. Example: code = ''' a = { 'x':1, 'y':2 } b = { **a, 'z'