[issue24915] Profile Guided Optimization active by-default

Brett Cannon added the comment: the v02 patches LGTM. I'm fine with seeing those committed as-is knowing Alecsandru is actively working towards Clang support. -- stage: patch review -> commit review ___ Python tracker

[issue24915] Profile Guided Optimization active by-default

Stefan Krah added the comment: I see that your latest patch leaves PGO as an option, so please ignore my previous comment. -- ___ Python tracker ___ _

[issue24915] Profile Guided Optimization active by-default

Stefan Krah added the comment: My initial reaction is that the default should be optimized for short build times. I would not want to type "disable-profile-opt" every time I'm running the tests. -- nosy: +skrah ___ Python tracker

[issue24915] Profile Guided Optimization active by-default

Changes by Alecsandru Patrascu : Added file: http://bugs.python.org/file40237/python3.6-pgo-v02.patch ___ Python tracker ___ ___ Python-bugs-l

[issue24915] Profile Guided Optimization active by-default

Changes by Alecsandru Patrascu : Added file: http://bugs.python.org/file40238/python2.7-pgo-v02-mac.patch ___ Python tracker ___ ___ Python-bu

[issue24915] Profile Guided Optimization active by-default

Alecsandru Patrascu added the comment: I modified the patches after the review made by Brett (python2.7-pgo-v02.patch and python3.6-pgo-v02.patch): - removed the call to pybench - left the PGO steps as optional. To use it we run "make profile-opt" - in the initial patches, I left out test_hashli

[issue24915] Profile Guided Optimization active by-default

Changes by Alecsandru Patrascu : Added file: http://bugs.python.org/file40239/python3.6-pgo-v02-mac.patch ___ Python tracker ___ ___ Python-bu

[issue24915] Profile Guided Optimization active by-default

Changes by Alecsandru Patrascu : Added file: http://bugs.python.org/file40236/python2.7-pgo-v02.patch ___ Python tracker ___ ___ Python-bugs-l

[issue24915] Profile Guided Optimization active by-default

Alecsandru Patrascu added the comment: I received the review and will post new patch versions as soon as I update them. Regarding PGO on clang, I will need a bit more time to edit the Makefile and will post it just for clang, to be easier for us to see the differences. -- __

[issue24915] Profile Guided Optimization active by-default

Brett Cannon added the comment: I did an initial code review on the 3.6 patch. What would it take to add clang support for PGO? Is it simply using different flags that configure can set in the generated Makefile? Or is it more involved and would require maintaining two separate compile lines i

[issue24915] Profile Guided Optimization active by-default

Skip Montanaro added the comment: It is executed using the gcc command: % gcc -c -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fprofile-generate -I. -IInclude -I./Include -DPy_BUILD_CORE -o Modules/gcmodule.o Modules/gcmodule.c clang: warning: argument unuse

[issue24915] Profile Guided Optimization active by-default

Alecsandru Patrascu added the comment: The patches are tested on Linux machines, with GNU GCC >4.8.3. From your output I see that you are using the CLANG compiler. CLANG uses a different set of flags for PGO that are not compatible with GCC's, therefore the compilation will fail. Can you pleas

[issue24915] Profile Guided Optimization active by-default

Skip Montanaro added the comment: Is this supposed to work on Macs using Apple's version of gcc? I've got the latest version of Yosemite and XCode, and am getting these warnings when trying to build 2.7: clang: warning: argument unused during compilation: '-fprofile-generate' Should this be e

[issue24915] Profile Guided Optimization active by-default

Alecsandru Patrascu added the comment: I added the patches as individual files and removed the zip file. -- ___ Python tracker ___ ___

[issue24915] Profile Guided Optimization active by-default

Changes by Alecsandru Patrascu : Removed file: http://bugs.python.org/file40226/python2.7-3.6-pgo.zip ___ Python tracker ___ ___ Python-bugs-l

[issue24915] Profile Guided Optimization active by-default

Changes by Alecsandru Patrascu : Added file: http://bugs.python.org/file40232/python3.6-pgo.patch ___ Python tracker ___ ___ Python-bugs-list

[issue24915] Profile Guided Optimization active by-default

Changes by Alecsandru Patrascu : -- keywords: +patch Added file: http://bugs.python.org/file40231/python2.7-pgo.patch ___ Python tracker ___ _

[issue24915] Profile Guided Optimization active by-default

Changes by Brett Cannon : -- nosy: +brett.cannon stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue24915] Profile Guided Optimization active by-default

Stefan Behnel added the comment: Please upload your patches as separate, uncompressed files for review. PGO was already proposed here, but nothing came out of it: https://bugs.python.org/issue17781 I suggest rejecting that old ticket and sticking with this one since it has an actual patch. -

[issue24915] Profile Guided Optimization active by-default

New submission from Alecsandru Patrascu: Hi All, This is Alecsandru from Server Scripting Languages Optimization team at Intel Corporation. I would like to submit a request to turn-on Profile Guided Optimization or PGO as the default build option for Python (both 2.7 and 3.6), given its perf