[issue24847] Can't import tkinter in Python 3.5.0rc1

Roundup Robot added the comment: New changeset dc9bdddca59b by Steve Dower in branch '3.5': Issue #24847: Removes vcruntime140.dll dependency from Tcl/Tk. https://hg.python.org/cpython/rev/dc9bdddca59b New changeset b77ceefc34ff by Larry Hastings in branch '3.5': Merged in stevedower/cpython350

[issue24847] Can't import tkinter in Python 3.5.0rc1

Changes by Larry Hastings : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ __

[issue24847] Can't import tkinter in Python 3.5.0rc1

Larry Hastings added the comment: Pull request accepted and merged. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: FYI - the Tcl and Tk changes have been committed upstream: http://core.tcl.tk/tcl/tktview/00189c4afcb9e2586301d711f71383e48817a72d -- ___ Python tracker _

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: Larry - PR for you at https://bitbucket.org/larry/cpython350/pull-requests/6/issue-24847-removes-vcruntime140dll/diff The buildbots are happy with this change, and so am I. Zach also had a look at the Tcl and Tk patches, and I've already heard back from upstream

[issue24847] Can't import tkinter in Python 3.5.0rc1

Roundup Robot added the comment: New changeset 0e2620831f17 by Steve Dower in branch '3.5': Issue #24847: Fixes Tix revision number and reverts fix for the wrong revision. https://hg.python.org/cpython/rev/0e2620831f17 New changeset 9cc3f2f2d810 by Steve Dower in branch 'default': Issue #24847:

[issue24847] Can't import tkinter in Python 3.5.0rc1

Roundup Robot added the comment: New changeset 19ac02a522ba by Steve Dower in branch '3.5': Issue #24847: Removes vcruntime140.dll dependency from Tcl/Tk. https://hg.python.org/cpython/rev/19ac02a522ba -- ___ Python tracker

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: Posting the actual changes made to Tcl and Tk, mainly so I can link them from the upstream issue I'm filing. -- Added file: http://bugs.python.org/file40206/tcltk_ucrt_option.patch ___ Python tracker

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: I'll withdraw my current pull request and make a new one tomorrow. I prefer to check into 3.5.1 immediately, and especially since this one will be covered by the buildbots, so I'll do that first. -- ___ Python tracker

[issue24847] Can't import tkinter in Python 3.5.0rc1

Robert Collins added the comment: Looks good to me. I think you should commit (or perhaps you are pending PR approval on the rc branch or something?) -- nosy: +rbcollins ___ Python tracker

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: Yeah, should have mentioned the smartscreen warning. The official builds are Authenticode signed, which prevents that warning appearing. I promise the installers are safe :) -- ___ Python tracker

[issue24847] Can't import tkinter in Python 3.5.0rc1

Matthew Barnett added the comment: On running the installer, Windows reports: """Windows SmartScreen prevented an unrecognised application from starting. Running this application might put your PC at risk. Application: Python-24847-2.exe Publisher: Unknown Publisher""" When installed, Tkinte

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: A second test build with the attached patches applied directly to 3.5.0rc1. (You'll need to remove the first test build before installing this). https://pythonbuilds.blob.core.windows.net/temp/python-24847-2.exe Any confirmation that these work would be appreciat

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: I've made a build of rc1 with the installer fix that's currently being considered for 3.5.0: https://pythonbuilds.blob.core.windows.net/temp/python-24847-1.exe (This is a test-marked build that *should not* affect another 3.5 install, but if it does please tell

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: I'll submit them upstream if we decide they're what we want, as I've done with other patches for them. Or if we want to figure out reliable builds with avcxproj I'm okay with that too. The fix that needs testing now is already checked in for 3.5.1. We just need

[issue24847] Can't import tkinter in Python 3.5.0rc1

Zachary Ware added the comment: To expand on 'unpalatable': I'd rather we not have to carry any patches against the Tcl/Tk sources (Tix I care less about, since we seem to be the de facto maintainers of it). -- ___ Python tracker

[issue24847] Can't import tkinter in Python 3.5.0rc1

Zachary Ware added the comment: I'll try to get a proper review done before Wednesday. From a cursory glance, this looks fine, but unpalatable. The solution I'd really like would be to create proper .vcxprojs for Tcl/Tk/Tix (partly because that would also fix an issue with building with ICC)

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: No, any machine with Visual Studio installed is unaffected by this. That buildbot seems to have a previous failed/aborted build that still has some files locked. A reboot is the easiest solution, but going through and killing any extra processes is what's needed

[issue24847] Can't import tkinter in Python 3.5.0rc1

R. David Murray added the comment: Is this buildbot failure: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.5/builds/189 related to this issue? LINK : fatal error LNK1104: cannot open file 'C:\buildbot.python.org\3.5.kloth-win64\build\PCBuild\amd64\_tkinter_d.pyd' [C:\bui

[issue24847] Can't import tkinter in Python 3.5.0rc1

Changes by Steve Dower : Added file: http://bugs.python.org/file40169/remove_vc140_py.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: Attaching two patches that fix the tcl/tk build to not require vcruntime140.dll at all. This is the better fix, though I haven't yet tested it thoroughly enough to convince myself that it's ready. One patch is for tcl/tk/tix themselves (which I'll submit upstream

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: Mark, IIRC you've got VS 2015? Anyone with VS 2015 installed (or the full CRT redistributable) is unaffected because the required file is already in their system path - this includes my build machine, which is why all my tkinter tests passed before pushing the re

[issue24847] Can't import tkinter in Python 3.5.0rc1

Mark Lawrence added the comment: Works fine for me, also on Windows 10 Home 64 bit. c:\Python35>python.exe Python 3.5.0rc1 (v3.5.0rc1:1a58b1227501, Aug 10 2015, 05:18:45) [MSC v.1900 64 bit (AMD64)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import tkint

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: Zach has the best chance of being able to review, if only because he can probably build the installer. I've added all the Windows experts just in case. There's quite a bit of MSBuild magic involved here though - I have trouble getting good reviews of this kind of

[issue24847] Can't import tkinter in Python 3.5.0rc1

Larry Hastings added the comment: I trust you, Steve, but I still want to see it get a review before I pull it. Can you find someone qualified to review the change? -- ___ Python tracker _

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: Pull request for 3.5.0 is at https://bitbucket.org/larry/cpython350/pull-requests/3/issue-24847-fixes-tcltk-installer-layout/diff. When merged, this can change back to normal priority for the rest of the fix. Long term (probably 3.5.1, possibly 3.5.0rc2 if I can

[issue24847] Can't import tkinter in Python 3.5.0rc1

Roundup Robot added the comment: New changeset 3cb97ffd9ddf by Steve Dower in branch '3.5': Issue #24847: Fixes tcltk installer layout of VC runtime DLL https://hg.python.org/cpython/rev/3cb97ffd9ddf New changeset 13ceedb92923 by Steve Dower in branch 'default': Issue #24847: Fixes tcltk install

[issue24847] Can't import tkinter in Python 3.5.0rc1

Matthew Barnett added the comment: Yes, I can confirm that that works for me. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue24847] Can't import tkinter in Python 3.5.0rc1

Steve Dower added the comment: Yep, this is my fix for the same issue pre-RC1 not quite working out (I'm guessing some difference between my dev box and my build box). If you go into your DLLs directory there's an extra subdirectory (Microsoft.VC140.CRT or similar) with a single DLL in it. Mov

[issue24847] Can't import tkinter in Python 3.5.0rc1

New submission from Matthew Barnett: I'm unable to import tkinter in Python 3.5.0rc1. The console says: C:\Python35>python Python 3.5.0rc1 (v3.5.0rc1:1a58b1227501, Aug 10 2015, 05:18:45) [MSC v.1900 64 bit (AMD64)] on win32 Type "help", "copyright", "credits" or "license" for more information.