[issue24735] Invalid access in combinations_with_replacement()

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue24735] Invalid access in combinations_with_replacement()

Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue24735] Invalid access in combinations_with_replacement()

STINNER Victor added the comment: Oh I see. Ok, since it's a corner case, I'm fine with no unit test. Thanks for the report Stefan, and thanks for the fix Raymond ;-) -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue24735] Invalid access in combinations_with_replacement()

Stefan Krah added the comment: Victor, there was no actual crash, just a potential one. In terms of the observable runtime behavior the code behaved correctly. I would not know what to test for, unless we set up a buildbot running Valgrind (which is impracticable for a number of reasons). -

[issue24735] Invalid access in combinations_with_replacement()

STINNER Victor added the comment: Can someone please write an unit test to avoid regressions in the future? -- nosy: +haypo resolution: fixed -> status: closed -> open ___ Python tracker __

[issue24735] Invalid access in combinations_with_replacement()

Changes by Raymond Hettinger : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue24735] Invalid access in combinations_with_replacement()

Roundup Robot added the comment: New changeset fd3fb122c5ff by Raymond Hettinger in branch '3.4': Issue #24735: Fix invalid memory access in combinations_with_replacement() https://hg.python.org/cpython/rev/fd3fb122c5ff -- nosy: +python-dev ___ Python

[issue24735] Invalid access in combinations_with_replacement()

Changes by Raymond Hettinger : -- Removed message: http://bugs.python.org/msg247505 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue24735] Invalid access in combinations_with_replacement()

Raymond Hettinger added the comment: Test case? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue24735] Invalid access in combinations_with_replacement()

Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue24735] Invalid access in combinations_with_replacement()

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue24735] Invalid access in combinations_with_replacement()

New submission from Stefan Krah: There's a corner case in cwr_next(), where the pool size is zero but pool[0] is accessed: from itertools import * it = combinations_with_replacement([], 0) next(it) Patch attached. -- components: Extension Modules files: itertools_invalid_access.diff