[issue24583] Crash when source set is changed during merging

Raymond Hettinger added the comment: Can you produce a test case? Perhaps the incref/decref pair ought to be moved into PyObject_RichCompareBool(). It doesn't make much sense for the callers to do the work. -- ___ Python tracker

[issue24583] Crash when source set is changed during merging

Serhiy Storchaka added the comment: LGTM for 3.5. But 3.6 has other bug. Changeset 637e197be547 looks incorrect to me. key should be increfed before calling PyObject_RichCompareBool() for the same reason as startkey. -- ___ Python tracker

[issue24583] Crash when source set is changed during merging

Changes by Serhiy Storchaka : -- Removed message: http://bugs.python.org/msg246469 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue24583] Crash when source set is changed during merging

Serhiy Storchaka added the comment: LGTM for 3.4. But 3.5 has other bug. Changeset 637e197be547 looks incorrect to me. key should be increfed before calling PyObject_RichCompareBool() for the same reason as startkey. -- ___ Python tracker

[issue24583] Crash when source set is changed during merging

Changes by Raymond Hettinger : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue24583] Crash when source set is changed during merging

Changes by Raymond Hettinger : Added file: http://bugs.python.org/file39883/index_to_entry.diff ___ Python tracker ___ ___ Python-bugs-list ma

[issue24583] Crash when source set is changed during merging

Changes by Raymond Hettinger : -- priority: normal -> high ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue24583] Crash when source set is changed during merging

Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue24583] Crash when source set is changed during merging

New submission from Serhiy Storchaka: When the set is not empty and set.update() argument is set that is modified during merging, the crash is caused. Here is a test that reproduces a crash. Only Python 3.5+ is affected. -- components: Interpreter Core files: test_set__merge_and_mutate