[issue24421] Race condition compiling Modules/_math.c

Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue24421] Race condition compiling Modules/_math.c

Roundup Robot added the comment: New changeset d4190ed586a4 by Martin Panter in branch '2.7': Issue #24421: Compile _math.c separately to avoid race condition https://hg.python.org/cpython/rev/d4190ed586a4 -- ___ Python tracker

[issue24421] Race condition compiling Modules/_math.c

Roundup Robot added the comment: New changeset a99580157968 by Martin Panter in branch '3.5': Issue #24421: Compile _math.c separately to avoid race condition https://hg.python.org/cpython/rev/a99580157968 -- ___ Python tracker

[issue24421] Race condition compiling Modules/_math.c

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue24421] Race condition compiling Modules/_math.c

Roundup Robot added the comment: New changeset 76624d47ee99 by Martin Panter in branch 'default': Issue #24421: Compile _math.c separately to avoid race condition https://hg.python.org/cpython/rev/76624d47ee99 -- nosy: +python-dev ___ Python tracker

[issue24421] Race condition compiling Modules/_math.c

Martin Panter added the comment: I am inclined to try committing my second patch to 3.6, as the race condition keeps bugging me every now and again. My biggest worry is that it may not work on Windows. I assume Windows does not use the Makefile, but does use setup.py. In the worst case, perhap

[issue24421] Race condition compiling Modules/_math.c

Martin Panter added the comment: Here is an alternative patch to compile _math.c once from the main makefile, before the extension modules are built. I have only tested this on Linux, building in the source directory, and from a separate directory. -- versions: -Python 3.4 Added file:

[issue24421] Race condition compiling Modules/_math.c

Martin Panter added the comment: Ideally, I think the solution would be to compile _math.c once, as a dependency shared between both extension modules (perhaps like a static library if necessary). Does anyone know if the build system supports this, or how to do it? Another semi-favourable solu

[issue24421] Race condition compiling Modules/_math.c

Changes by Mike Gilbert : -- nosy: +floppymaster ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue24421] Race condition compiling Modules/_math.c

Tal Einat added the comment: Adding Thomas Wouters to the nosy list, since he's listed on the Experts Index under "autoconf/makefiles" as an interest area. Hopefully he can help move this forward. -- nosy: +twouters ___ Python tracker

[issue24421] Race condition compiling Modules/_math.c

Martin Panter added the comment: Here is a hacky patch that adds #include "_math.c" so that it is not compiled as a separate object file. This was suggested by Mark in Issue 7518. It is far from a perfect solution, but I cannot suggest anything better without knowing more about Python’s build

[issue24421] Race condition compiling Modules/_math.c

Martin Panter added the comment: I think this may have been introduced when _math.c was added as a source file of the “cmath” module in r76978 (Issue 7518). In /setup.py:585 there are two distutils.core.Extension objects, both mentioning _math.c. In the build_ext._build_extensions_parallel() m

[issue24421] Race condition compiling Modules/_math.c

Tal Einat added the comment: Confirmed on OSX 10.10. Here's my output: running build running build_ext building 'cmath' extension ./slow-cc.py -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -Werror=declaration-after-statement -I./Include

[issue24421] Race condition compiling Modules/_math.c

New submission from Martin Panter: Once or twice I have had the math or cmath modules fail to build. There seems to be a race condition, because the _math.c file seems to be compiled twice, once for each module. Attached is a GCC wrapper that should help reproduce this fairly consistently. Fir