[issue24348] incorrect decref in C OrderedDict

2015-06-01 Thread Eric Snow
Changes by Eric Snow : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ ___ Pytho

[issue24348] incorrect decref in C OrderedDict

2015-06-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8631b88c23f6 by Eric Snow in branch '3.5': Issue #24348: Drop superfluous increfs/decrefs. https://hg.python.org/cpython/rev/8631b88c23f6 -- nosy: +python-dev ___ Python tracker

[issue24348] incorrect decref in C OrderedDict

2015-06-01 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue24348] incorrect decref in C OrderedDict

2015-06-01 Thread Yury Selivanov
Changes by Yury Selivanov : -- nosy: +yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue24348] incorrect decref in C OrderedDict

2015-06-01 Thread Eric Snow
New submission from Eric Snow: (from msg244575 in issue16991) crash-2.py is due to the fact that _PyDict_Pop() deletes a reference to 'key' in _odict_popkey(). The INCREF(key) in popitem should take place before calling _odict_popkey(). Again, I don't see the point of INCREF/DECREF *inside* o