[issue24334] SSLSocket extra level of indirection

Christian Heimes added the comment: New changeset 1a0bb626f4cfd95f7ec406ea7d3f9433def559fc by Christian Heimes (Miss Islington (bot)) in branch '3.7': [3.7] bpo-24334: Remove inaccurate match_hostname call (GH-6211) (#6212) https://github.com/python/cpython/commit/1a0bb626f4cfd95f7ec406ea7d3f9

[issue24334] SSLSocket extra level of indirection

Change by miss-islington : -- pull_requests: +5957 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue24334] SSLSocket extra level of indirection

Christian Heimes added the comment: New changeset e42ae915095ebca789cc36f3a336a3331fe35945 by Christian Heimes in branch 'master': bpo-24334: Remove inaccurate match_hostname call (#6211) https://github.com/python/cpython/commit/e42ae915095ebca789cc36f3a336a3331fe35945 -- __

[issue24334] SSLSocket extra level of indirection

Change by Christian Heimes : -- pull_requests: +5956 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue24334] SSLSocket extra level of indirection

Christian Heimes added the comment: Thanks for your review, Antoine! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 -Python 3.6 ___ Python tracker __

[issue24334] SSLSocket extra level of indirection

Christian Heimes added the comment: New changeset 8fa8478ddeba0870da1152f0a2985c8a7eeb9fd1 by Christian Heimes (Miss Islington (bot)) in branch '3.7': [3.7] bpo-24334: Cleanup SSLSocket (GH-5252) (#5857) https://github.com/python/cpython/commit/8fa8478ddeba0870da1152f0a2985c8a7eeb9fd1 --

[issue24334] SSLSocket extra level of indirection

Change by miss-islington : -- pull_requests: +5632 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue24334] SSLSocket extra level of indirection

Christian Heimes added the comment: New changeset 141c5e8c2437a9fed95a04c81e400ef725592a17 by Christian Heimes in branch 'master': bpo-24334: Cleanup SSLSocket (#5252) https://github.com/python/cpython/commit/141c5e8c2437a9fed95a04c81e400ef725592a17 -- __

[issue24334] SSLSocket extra level of indirection

Change by Christian Heimes : -- pull_requests: +5099 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list m

[issue24334] SSLSocket extra level of indirection

Changes by Christian Heimes : -- assignee: -> christian.heimes components: +SSL ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue24334] SSLSocket extra level of indirection

Changes by Christian Heimes : -- versions: +Python 3.7 -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue24334] SSLSocket extra level of indirection

Antoine Pitrou added the comment: > I made SSLSocket go through SSLObject so that the test suite that is > primarily testing SSLSocket will test both. Indeed, I like the fact it makes test coverage broader. Of course, if there's another way to get such coverage without duplicating lots of cod

[issue24334] SSLSocket extra level of indirection

Geert Jansen added the comment: Apologies for the late reply. I made SSLSocket go through SSLObject so that the test suite that is primarily testing SSLSocket will test both. Also, this layering allows us to define some non-networked operations (such as SSL certificate checking and channel bi

[issue24334] SSLSocket extra level of indirection

Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue24334] SSLSocket extra level of indirection

Antoine Pitrou added the comment: I'm nosying Geert, who is the original author of the SSLObject code. -- nosy: +geertj ___ Python tracker ___ ___

[issue24334] SSLSocket extra level of indirection

New submission from Christian Heimes: I just noticed that #21965 has added an extra level of indirection to the SSLSocket object. In Python 3.4 and earlier the ssl.SSLSocket object has one level of indirection: >>> import ssl >>> ctx = ssl.create_default_context() >>> sock = ssl.create_connect